From: Keir Fraser Subject: Re: [PATCH xen-unstable] Remove PSE flag from guest CR4 Date: Mon, 14 Sep 2009 18:42:16 +0100 Message-ID: References: <200909141227.16852.dcm@mccr.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200909141227.16852.dcm@mccr.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dave McCracken , Xen Developers List Cc: Jeremy Fitzhardinge List-Id: xen-devel@lists.xenproject.org If you hide PSE in CR4 and CPUID, how does the guest know it can use superpages? -- Keir On 14/09/2009 18:27, "Dave McCracken" wrote: > > When I originally did the Xen hypervisor hugepage patch I also allowed guests > to see the PSE flag in CR4. This has proven to be a mistake. Here is a patch > to remove that functionality. > > All Linux kernels will still allow userspace hugepages without the flag. > > Dave McCracken