From: Keir Fraser Subject: Re: [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation while its IRQ is masked Date: Wed, 16 Sep 2009 10:09:10 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Cui, Dexuan" , Kouya Shimura Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Perhaps. Anyway, the patches fixed bugs and generally cleaned up some logic, so I think they are good for reasons other than the few saved cycles on vmenter. -- Keir On 16/09/2009 09:40, "Cui, Dexuan" wrote: > I'm not sure if the number of the saved cycles is the same on recent Intel > CPUs, so the proportion may not be greater. :-) > > Thanks, > -- Dexuan > > -----Original Message----- > From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] > Sent: 2009?9?16? 16:21 > To: Cui, Dexuan; Kouya Shimura > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation > while its IRQ is masked > > On 16/09/2009 09:00, "Cui, Dexuan" wrote: > >> Looks the little win doesn't deserve the increased complexity in code. >> >> BTW, recent Intel CPUs run much faster with respect to VMEntry/VMExit and >> VMREAD/VMWRITE, so I don't think the SW optimizatin is appearling here. :-) > > Makes it more appealing doesn't it? As this path will be a greater > proportion of an overall vmexit/vmenter cycle. > > -- Keir