From: Keir Fraser Subject: Re: [PATCH] trust new architecturally-defined TSC Invariant bit on Intel systems Date: Fri, 09 Oct 2009 20:20:40 +0100 Message-ID: References: <8099ee0f-6c0d-4966-ae07-bea9951dd272@default> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8099ee0f-6c0d-4966-ae07-bea9951dd272@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer , "Xen-Devel (E-mail)" List-Id: xen-devel@lists.xenproject.org On 09/10/2009 20:03, "Dan Magenheimer" wrote: > Actually it did (avoid rendezvous), but I have to admit > it was accidental: I was trying to avoid the write_tsc's > not the rendezvous, and I didn't notice the additional > implication until I was looking at the difference between > my patch and yours. > > I'll look at this more in a few days... If you mean your test-and-goto in time_calibration_tsc_rendezvous(), that was just broken. You still raised the TIME_CALIBRATE_SOFTIRQ, but with uninitialised r->master_stime. And at that point you'd already rendezvoused all the CPUs, so done the expensive bit anyway. -- Keir