From: Keir Fraser Subject: Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails Date: Sat, 17 Oct 2009 15:15:35 +0100 Message-ID: References: <20091017135132.GA30062@movementarian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091017135132.GA30062@movementarian.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon , George Dunlap Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 17/10/2009 14:51, "John Levon" wrote: > On Fri, Oct 16, 2009 at 02:09:20PM +0100, George Dunlap wrote: > >> domain is dying, and makes an ASSERT() to that effect. So currently, >> in debug mode, this will cause the host to crash; in non-debug mode, >> this will cause a page-fault loop. > > Isn't this a security hole then? Debug builds shouldn't be used in production environments. The page-fault loop, in the non-debug case, is preemptible, so the offending guest can only waste its own scheduling quantum. -- Keir