From: Keir Fraser Subject: Re: [PATCH] x86 boot: simplify reloc.c Date: Tue, 10 Nov 2009 07:36:49 +0000 Message-ID: References: <4AF8DF5D.2090306@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4AF8DF5D.2090306@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xiao Guangrong Cc: xen-devel , Xiao Guangrong List-Id: xen-devel@lists.xenproject.org On 10/11/2009 03:34, "Xiao Guangrong" wrote: > This patch simplify reloc.c with: > 1): no need separate make > reloc.c -> reloc.o -> reloc.lnk -> reloc.bin -> reloc.S, > and static embed reloc.S into head.S > 2): reuse memcpy() in string lib > 3): remove assemble code in the head of reloc.c > > [ It is just a cleanup patch and not change the code's logic, and it work well > on x86. > Not have x86_64 machine in my hand, thanks very much if someone can test it > on x86_64 ] The patch misses the point of reloc.c, which is that it is supposed to run in 32-bit mode. All the stuff you stripped out is exactly what's needed to make it work with 64-bit Xen. -- Keir