From: Keir Fraser Subject: Re: [PATCH 3 of 5] pygrub: factor generic Grub functionality into GrubConf base classes Date: Mon, 23 Nov 2009 07:20:55 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "ian.campbell@citrix.com" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 22/11/2009 19:15, "ian.campbell@citrix.com" wrote: > pygrub: factor generic Grub functionality into GrubConf base classes > and inherit from these classes to implement Grub-legacy functionality. > > Use a tuple of (parser-object,configuration-file) in pygrub to allow > for multiple parsers. > > Makes way for grub2 support. This patch didn't apply for me. It may be due to mangling at my end or yours because of sending the patch inline. Try resending it as an attachment, along with patches 4/5 and 5/5 (I have already successfully applied 1/5 and 2/5). Thanks, Keir