From: Keir Fraser Subject: Re: [PATCH] libxc: failure to save/restore 32bit HVM guest Date: Tue, 24 Nov 2009 08:48:16 +0000 Message-ID: References: <20091123151406.36e032c8@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091123151406.36e032c8@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mukesh Rathor , "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 23/11/2009 23:14, "Mukesh Rathor" wrote: > Following appears to be an obvious bug. Save/restore of HVM guests > works fine after the following fix. Including the patch, please let me > know if you agree. I'll make parallel fix in our previous versions > here. Save/restore of HVM guests should work fine before this fix too, since nothing in xc_core.c is used for guest save/restore. It's used for core dumps, as the name implies, and which is a rather different thing. Furthermore I think the code in xc_core.c is correct as is. -- Keir