From: Keir Fraser Subject: Re: [PATCH] libxc: failure to save/restore 32bit HVM guest Date: Tue, 24 Nov 2009 19:58:48 +0000 Message-ID: References: <20091124112348.7542f11d@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091124112348.7542f11d@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mukesh Rathor Cc: "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 24/11/2009 19:23, "Mukesh Rathor" wrote: > Anyways, since 32bit HVM returns 64bit contexts, it appears the way it > is, is buggy, since the sizeof(ctxt[0].c) will return 32bit context > size in 32 bit libxc. Infact, after making the fix, user is able to get > proper core of a Java HVM guest. Can you please quickly explain why you > think it's correct in such case? Ah, maybe you are right after all. But shouldn't you change the last two arguments in the call: sts = xc_core_shdr_set(shdr, strtab, XEN_DUMPCORE_SEC_PRSTATUS, SHT_PROGBITS, offset, filesz, __alignof__(ctxt[0].c), sizeof(ctxt[0].c)); ...to reference *ctxt instead of ctxt[0].c, as well? If you agree, send an updated patch and I'll apply it. -- Keir