From: Keir Fraser Subject: Re: [PATCH] cleanup for __start_xen() Date: Mon, 30 Nov 2009 18:52:41 +0000 Message-ID: References: <19220.1000.264592.235805@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19220.1000.264592.235805@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Xiao Guangrong , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 30/11/2009 17:42, "Ian Jackson" wrote: > I wrote: >> Xiao Guangrong writes ("[Xen-devel] [PATCH] cleanup for __start_xen()"): >>> - if ( !initial_images_start && (s < e) && >>> + if ( !initial_images_start && >> >> This is wrong. s and e are uint64_t so if !(s < e), (e-s) will be >> large and positive. > > I see this has already been applied (20523). It should be reverted, I > think. None of the if() blocks in the loop will make e=s. But now I look at it I think I broke the module-relocation block some time ago -- it ends up with 'e' being too large by modules_headroom. :-( Will look into that more tomorrow... -- Keir