From: Keir Fraser Subject: Re: [PATCH] cleanup for __start_xen() Date: Tue, 01 Dec 2009 12:07:57 +0000 Message-ID: References: <20091201094217.GI14284@whitby.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091201094217.GI14284@whitby.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan , Xiao Guangrong Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 01/12/2009 09:42, "Tim Deegan" wrote: > At 01:16 +0000 on 01 Dec (1259630197), Xiao Guangrong wrote: >> e is moved in [e-(modules_length+modules_headroom), e] range, >> so, s is not overrun e too... > > OK, but: > - this is not obvious (hence this thread); > - even Keir makes mistakes here from time to time; and > - it's a single test on code that runs at start of day > so maybe we should just leave it as it was? I'll put it back and fix my other pre-existing mistake also. -- Keir