From: Keir Fraser Subject: Re: [PATCH 0 of 3] Remus: control tool Date: Wed, 02 Dec 2009 08:07:40 +0000 Message-ID: References: <4B15A111.1050004@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B15A111.1050004@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge , "pasik@iki.fi" , "konrad.wilk@oracle.com" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 01/12/2009 23:04, "Jeremy Fitzhardinge" wrote: > What's the bug? I don't see a reentrancy issue there because the > suspend happens synchronously in the xenwatch thread under > xenwatch_mutex. Or race for that matter. > > Am I missing something? > > > Of course, if you start triggering suspends via event channels, we'll > need to work out something else. The issue in 2.6.18 was that, if doing back-to-back save/restores, the next event-channel notification could come in before domU was finished with previous s/r cycle, and then the notification got dropped. There are a number of ways of dealing with that of course: I implemented a little state machine; or you could probably do it with some kind of ticket-based scheme; or perhaps have the evtchn irq handler spawn a kthread which blocks on the mutex (I liked that one least as it needs to allocate resources). -- Keir