From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] xend: Fix non-contiguous NUMA node assignment
Date: Mon, 18 Jan 2010 09:19:44 +0000
Message-ID: <C779D830.67D1%keir.fraser@eu.citrix.com>
References: <4B542170.6000202@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B542170.6000202@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Andre Przywara <andre.przywara@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "yunhong.jiang@intel.com" <yunhong.jiang@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 18/01/2010 08:53, "Andre Przywara" <andre.przywara@amd.com> wrote:

> Keir Fraser wrote:
>> I had a go myself: see c/s 20817. This keeps nr_nodes as well as
>> max_node_id, and continues to use it where it seemed to make sense to do so.
> 
> c/s 20817 seems OK to me. Actually that was how I started, but then
> decided to drop max_node_id because I didn't see the sense in keeping
> two variables which actually differ just by 1.

They don't merely differ by one if there are holes in the node-id namespace.
Can that happen in practice? I'm not sure; but it's easy enough for the
tools to handle that case, so they might as well.

 -- Keir