From: Keir Fraser Subject: Re: [PATCH][v2] Hybrid extension support in Xen Date: Tue, 02 Feb 2010 13:35:23 +0000 Message-ID: References: <1265109741.2965.22412.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1265109741.2965.22412.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell , Sheng Yang Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 02/02/2010 11:22, "Ian Campbell" wrote: > On Tue, 2010-02-02 at 08:16 +0000, Sheng Yang wrote: >> >> +/* Reserve 128KB for grant table */ >> +#define GNTTAB_MEMBASE 0xfbfe0000 >> +#define GNTTAB_MEMSIZE 0x20000 > > Why is this necessary? Isn't the grant table contained within one of the > BARS on the virtual PCI device? What needs grant tables for prior to the > kernel finding the PCI device which necessitates hardcoding these > addresses in both guest and hypervisor? I didn't even find where these get used, except to reserve an area in e820, and it wasn't clear why that reservation is necessary. -- Keir