From: Keir Fraser Subject: Re: [PATCH] new commands "xl reboot" & "xl shutdown" Date: Thu, 13 May 2010 08:41:50 +0100 Message-ID: References: <4BEAE0B0.9040403@flexiant.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BEAE0B0.9040403@flexiant.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Gihan Munasinghe , Vincent Hanquez Cc: Xen Devel List-Id: xen-devel@lists.xenproject.org On 12/05/2010 18:09, "Gihan Munasinghe" wrote: >> the if (/* hvm */ 0) is because the function never properly tested if >> the domain is hvm or not. nowadays you have is_hvm(domid) function >> that can handily replace the hardcoded value. >> > Yes having is_hvm is much better than the hard coded values I have > changed that bit of code see attached patch. Please port your patch to the tip of xen-unstable and re-post with changeset comment and signed-off-by-line. Thanks, Keir