From: Keir Fraser Subject: Re: [PATCH] tools: gpxe build fix Date: Wed, 21 Jul 2010 17:02:07 +0100 Message-ID: References: <19527.5438.131099.513012@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19527.5438.131099.513012@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Christoph Egger Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 21/07/2010 16:41, "Ian Jackson" wrote: > Christoph Egger writes ("[Xen-devel] [PATCH] tools: gpxe build fix"): >> On NetBSD, uname -m prints 'amd64'. >> Attached patch makes gpxe aware of that. > > Are there any other systems on which uname -m prints amd64 on which > this patch will break ? > > I think calling a patch "Makefile.patch" is going to be annoying. > And patches in a series should not be named just after the file they > change as if only one patch touches each file. > > How about "makefile-amd64.patch" ? > > Also "gpxe build fix" is a hopeless commit message. I ended up upgrading us to far more recent gpxe, where this whole issue has simply disappeared. -- Keir > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel