From: Keir Fraser Subject: Re: [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge. Date: Fri, 29 Oct 2010 14:16:56 +0100 Message-ID: References: <20101029131110.GN2804@reaktio.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20101029131110.GN2804@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Pasi =?ISO-8859-1?B?S+Rya2vkaW5lbg==?= , anthony.perard@citrix.com Cc: Xen Devel List-Id: xen-devel@lists.xenproject.org On 29/10/2010 14:11, "Pasi K=E4rkk=E4inen" wrote: >> Xen will register the old ioport by default and switch to the new ioport= if >> the >> HVM_PARAM_ACPI_NEW_IOPORT is set. So, this series come with a new functi= on, >> unregister_io_handler, and a new HVM_PARAM. >>=20 >=20 > Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ? > After a couple of years "NEW" might not make much sense anymore.. >=20 > IOPORT_V2 ? Or something.. I've asked for a nice big explanatory comment to be added beside the parameter's definition. Also we should treat this field as a version number= , so baking a fixed version into its name is not a good idea. With the explanatory comment, I think its existing name is good enough. To do much better the name would have to become cumbersomely long. -- Keir