From: Keir Fraser Subject: Re: [PATCH 1/4] amd iommu: Large io page support - Interface Date: Fri, 03 Dec 2010 08:21:03 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Wang2 , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Also the patch uses but does not define amd_iommu_map_pages(). Looks like you took one big patch and arbitrarily cut it up into a patch series. That is pointless if the series does not step-wise build and work. -- Keir On 03/12/2010 08:17, "Keir Fraser" wrote: > Why add new map/unmap calls. Better just to extend the existing calls to = be > able to act on a range, eh? That way you won't end up stubbing out and > breaking Intel support in patch 3, either... >=20 > -- Keir >=20 > On 03/12/2010 08:03, "Wei Wang2" wrote: >=20 >> This patch extends generic iommu interfaces to support different page si= ze. >>=20 >> Thanks, >> Wei >> Signed-off-by: Wei Wang >> -- >> Legal Information: >> Advanced Micro Devices GmbH >> Sitz: Dornach, Gemeinde Aschheim, >> Landkreis M=FCnchen Registergericht M=FCnchen, >> HRB Nr. 43632 >> Gesch=E4ftsf=FChrer: >> Alberto Bozzo, Andrew Bowd >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >=20 >=20