From: Keir Fraser Subject: Re: [PATCH 2/4] amd iommu: Large io page support - parameter Date: Fri, 03 Dec 2010 08:29:37 -0800 Message-ID: References: <201012031719.38516.wei.wang2@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <201012031719.38516.wei.wang2@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Wang2 Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 03/12/2010 08:19, "Wei Wang2" wrote: > Keir, > It could be used to disable super iommu page if the new codes have some > issues. But I am OK with removing it if you think this parameter is > unnecessary.=20 Yeah there's a judgement call there. But we don't add command-line flags fo= r every new feature we implement, and in this case I don't think it's worthwhile. The iommu=3D set of parameters is hairy enough as it is. We can always add the parameter *if* it proves to be worthwhile. -- Keir > Thanks, > Wei > =20 > On Friday 03 December 2010 17:14:12 Keir Fraser wrote: >> Why? If the system supports superpages, use them. Simple. >>=20 >> -- Keir >>=20 >> On 03/12/2010 08:03, "Wei Wang2" wrote: >>> Add a xen parameter (iommu=3Dsuperpage) to enable iommu super page. >>> Thanks, >>> We >>> Signed-off-by: Wei Wang >>> -- >>> Legal Information: >>> Advanced Micro Devices GmbH >>> Sitz: Dornach, Gemeinde Aschheim, >>> Landkreis M=FCnchen Registergericht M=FCnchen, >>> HRB Nr. 43632 >>> Gesch=E4ftsf=FChrer: >>> Alberto Bozzo, Andrew Bowd >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >=20 >=20 >=20