DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0F157606A336
Precedence: list
MIME-Version: 1.0
References: <20261109-halliday-dts-v1-0-289114ab8197@gmail.com>
 <20261109-halliday-dts-v1-17-289114ab8197@gmail.com> <sashiko-outbox-204265@kernel.org>
In-Reply-To: <sashiko-outbox-204265@kernel.org>
From: Stanislav Aleksandrov <lightofmysoul@gmail.com>
Date: Mon, 9 Nov 2026 01:10:31 +0000
Message-ID: <CAEo19Oh8jtyBZXWRs5a0g2N6tBvSY+=SoF_507Wu1SdmbBNpiQ@mail.gmail.com>
Subject: Re: [PATCH 17/17] arm64: dts: qcom: Add Samsung Galaxy XR
To: sashiko-reviews@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

"headset" was added to dt-schema recently:
https://github.com/devicetree-org/dt-schema/commit/bcb597bbb0c988b490fdd6ed=
08d023d6ddc538b9

=D0=BF=D0=BD, 9 =D0=BD=D0=BE=D1=8F=D0=B1. 2026=E2=80=AF=D0=B3. =D0=B2 00:57=
, <sashiko-bot@kernel.org>:
>
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] arm64: dts: qcom: invalid chassis-type value in
>   halliday-samsung-xrvst2.dts
> --
>
> commit d2d9cbc7744fd9c3d95a63b1d3df85d5cbe99afb
> Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>
>
> arm64: dts: qcom: Add Samsung Galaxy XR
>
> This commit adds the device tree for the Samsung Galaxy XR headset based
> on the Qualcomm Halliday SoC (SXR2250P).
>
> > diff --git a/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts b/arc=
h/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> > new file mode 100644
> > index 0000000000000..6fcc1aaafd59c
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> > @@ -0,0 +1,218 @@
> [ ... ]
> > +/ {
> > +     model =3D "Samsung Galaxy XR";
> > +     compatible =3D "samsung,xrvst2", "qcom,halliday";
> > +     chassis-type =3D "headset";
>
> [Severity: Low]
> Is "headset" a valid value for chassis-type in the root node?  The
> Devicetree Specification and dtschema (schemas/root-node.yaml) only permi=
t
> desktop, laptop, convertible, server, tablet, handset, watch, embedded,
> television, and all-in-one, so dtbs_check fails on this DTB unless a
> standard value (such as "embedded") is used or chassis-type is omitted.
>
> --
> Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261109-halliday=
-dts-v1-0-289114ab8197@gmail.com?part=3D17