Received: from eggs.gnu.org ([2001:4830:134:3::10]:50156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtLrc-0001cf-PT for qemu-devel@nongnu.org; Wed, 18 Dec 2013 13:29:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtLrW-0004DB-MO for qemu-devel@nongnu.org; Wed, 18 Dec 2013 13:28:56 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) From: Alexander Graf In-Reply-To: <87haa69hdy.fsf@linux.vnet.ibm.com> Date: Wed, 18 Dec 2013 19:29:07 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1383834423-11719-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <7E9EE0FC-EFAC-4DBB-8BB4-B59510713E19@suse.de> <87haa69hdy.fsf@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH -V2] kvm: Add a new machine property kvm_type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: "qemu-ppc@nongnu.org list:PowerPC" , Paul Mackerras , QEMU Developers , Paolo Bonzini On 18.12.2013, at 18:51, Aneesh Kumar K.V = wrote: > Alexander Graf writes: >=20 >> On 07.11.2013, at 15:27, Aneesh Kumar K.V = wrote: >>=20 >>> From: "Aneesh Kumar K.V" >>> diff --git a/hw/ppc/e500plat.c b/hw/ppc/e500plat.c >>> index 2e964b2..4be4b24 100644 >>> --- a/hw/ppc/e500plat.c >>> +++ b/hw/ppc/e500plat.c >>> @@ -17,6 +17,7 @@ >>> #include "hw/pci/pci.h" >>> #include "hw/ppc/openpic.h" >>> #include "kvm_ppc.h" >>> +#include "kvmtype.h" >>>=20 >>> static void e500plat_fixup_devtree(PPCE500Params *params, void *fdt) >>> { >>> @@ -51,6 +52,7 @@ static QEMUMachine e500plat_machine =3D { >>> .desc =3D "generic paravirt e500 platform", >>> .init =3D e500plat_init, >>> .max_cpus =3D 32, >>> + .kvm_type =3D pr_kvm_type, >>=20 >> What about mpc8544ds? Also, e500plat can definitely support HV >> (e500mc+) and PR (e500v2) mode. So you probably want the same check >> here as you have in spapr. >=20 > I don't have access to the hardware to validate. So at this point, I > would suggest we change the code such that we don't change the > functionality. Works for me. Please accept neither PR nor HV then, but only leave the = default. >=20 >>=20 >> Unfortunately the patch doesn't apply anymore. Would you care to >> rebase it? I think it's also more targeted towards the kvm queue >> rather than the ppc queue, so I'd either like an ack from Paolo or >> would defer to his tree for inclusion :). >=20 >=20 > Will resend Thanks! Alex