From: "Dilger, Andreas" Date: Wed, 04 Nov 2015 01:43:03 +0000 Subject: Re: [lustre-devel] [patch] staging: lustre: remove unused variable Message-Id: List-Id: References: <20151103221616.GD19280@mwanda> In-Reply-To: <20151103221616.GD19280@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lustre-devel@lists.lustre.org On 2015/11/03, 15:38, "Simmons, James A." wrote: >>The "->lr_lvb_data" struct member is never used. Delete it. >> >>Signed-off-by: Dan Carpenter >>--- >>I have compile tested this. I looked through the history and it seems >>to never have been used. I wonder if we can remove the locking as well. > >This is used by the quota and ofd layer which are both server side. When the server code is merged upstream this can be added to a union that contains only server-side data that overlaps with a union containing only client-side data. For now it is fine to remove from the kernel. Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division