From: "Handrigan, Paul" Subject: Re: [PATCH 1/2] ASoC: cs35l33: Fix testing return value of devm_gpiod_get_optional Date: Thu, 30 Jun 2016 15:36:10 +0000 Message-ID: References: <1467245614.7105.2.camel@ingics.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by alsa0.perex.cz (Postfix) with ESMTP id 36B5F2651DB for ; Thu, 30 Jun 2016 17:36:13 +0200 (CEST) In-Reply-To: <1467245614.7105.2.camel@ingics.com> Content-Language: en-US Content-ID: <0A5CFE12CA19EC459E238854229228C1@ad.cirrus.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Axel Lin , Mark Brown Cc: "Austin, Brian" , Liam Girdwood , "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org On 6/29/16, 7:13 PM, "Axel Lin" wrote: >devm_gpiod_get_optional() returns NULL when the gpio is not assigned. >So the if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) test is always false. > >Signed-off-by: Axel Lin >--- > sound/soc/codecs/cs35l33.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c >index 622a111..aa5c0c5 100644 >--- a/sound/soc/codecs/cs35l33.c >+++ b/sound/soc/codecs/cs35l33.c >@@ -1176,11 +1176,7 @@ static int cs35l33_i2c_probe(struct i2c_client >*i2c_client, > /* We could issue !RST or skip it based on AMP topology */ > cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, > "reset-gpios", GPIOD_OUT_HIGH); >- >- if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) { >- dev_warn(&i2c_client->dev, >- "%s WARNING: No reset gpio assigned\n", __func__); >- } else if (IS_ERR(cs35l33->reset_gpio)) { >+ if (IS_ERR(cs35l33->reset_gpio)) { > dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", > __func__); > return PTR_ERR(cs35l33->reset_gpio) Acked-by: Paul Handrigan