Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A89CEC5B543 for ; Tue, 10 Jun 2025 10:12:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2EEDA82A39; Tue, 10 Jun 2025 12:12:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="GyV9Yk8i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F66382AC4; Tue, 10 Jun 2025 12:12:01 +0200 (CEST) Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 834A38070C for ; Tue, 10 Jun 2025 12:11:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=anshuld@ti.com Received: from lelvem-sh02.itg.ti.com ([10.180.78.226]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTP id 55AABuar1051445; Tue, 10 Jun 2025 05:11:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1749550316; bh=+U/4wQi+DUWnF6kg3lR0WtIX5XW0HWXefWoKdooAth4=; h=Date:CC:Subject:From:To:References:In-Reply-To; b=GyV9Yk8i0FwnIoT6NfFFGR/9L0Zj4CihVOhiq3HmuWPNxiZc/4v+BSpJ3s02EWj+T eDNiMIjtvSqQ/lbDVrvXwnqt5d6UXUKIsj5GLSElTYXP+l24k+Oo+28H4H/9vWVh2f FDFgA5U+qInipvQmp8CGvMmzUzAS/wHyeV/l7/38= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelvem-sh02.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 55AABugg2046852 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 10 Jun 2025 05:11:56 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 10 Jun 2025 05:11:56 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 10 Jun 2025 05:11:56 -0500 Received: from localhost (dhcp-172-24-227-250.dhcp.ti.com [172.24.227.250]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 55AABtlB2745147; Tue, 10 Jun 2025 05:11:56 -0500 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Date: Tue, 10 Jun 2025 15:41:21 +0530 Message-ID: CC: , , , , , , , Subject: Re: [PATCH v7 07/10] board: ti: add default dtb for am62 in falcon mode From: Anshul Dalal To: Tom Rini X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250603142452.2707171-1-anshuld@ti.com> <20250603142452.2707171-8-anshuld@ti.com> <20250606190956.GA1382132@bill-the-cat> <20250609145716.GM1382132@bill-the-cat> In-Reply-To: <20250609145716.GM1382132@bill-the-cat> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon Jun 9, 2025 at 8:27 PM IST, Tom Rini wrote: > On Mon, Jun 09, 2025 at 01:05:36PM +0530, Anshul Dalal wrote: >> On Sat Jun 7, 2025 at 12:39 AM IST, Tom Rini wrote: >> > On Tue, Jun 03, 2025 at 07:54:47PM +0530, Anshul Dalal wrote: >> > >> >> The SPL_FS_LOAD_ARGS_NAME config is used for the arguments to the ker= nel >> >> (dtb in our case) in falcon boot. >> >>=20 >> >> Setting it in board specific Kconfig allows us to reuse the same conf= ig >> >> fragment 'am62x_r5_falcon.config' for all 3 platforms for enabling >> >> falcon boot. >> >>=20 >> >> Signed-off-by: Anshul Dalal >> >> --- >> >> board/ti/am62ax/Kconfig | 3 +++ >> >> board/ti/am62px/Kconfig | 3 +++ >> >> board/ti/am62x/Kconfig | 3 +++ >> >> 3 files changed, 9 insertions(+) >> > >> > Why can't whatever is using the fragment also set this? Is it because >> > you're only using this as part of say: >> > make am62ax_evm_r5_defconfig am62x_falcon.config >> > ? >>=20 >> Correct, having three different config fragments with only changes to th= e >> dtb path doesn't seem very useful imo. > > Then these belong back in the main defconfig itself I think. That's not an option since SPL_FS_LOAD_ARGS_NAME depends on SPL_OS_BOOT[1] and due to the way config fragments are applied. Since we only set OS_BOOT to y inside of the fragment, we can not define any configs that depend on it before that in the defconfig like SPL_FS_LOAD_ARGS_NAME, it would just default to "args" instead. [1]: common/spl/Kconfig:794 config SPL_FS_LOAD_ARGS_NAME string "File to load for the OS kernel argument parameters from the filesy= stem" depends on (SPL_FS_EXT4 || SPL_FS_FAT || SPL_FS_SQUASHFS) && SPL_OS_BOOT default "args"