Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 16 Jul 2025 10:40:47 +0900
Message-Id: <DBD3I0RWQ39M.XA1Q0WSOJWSE@nvidia.com>
Cc: <rust-for-linux@vger.kernel.org>, <airlied@gmail.com>,
 <simona@ffwll.ch>, <nouveau@lists.freedesktop.org>,
 <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpu: nova-core: vbios: split out PmuLookupTableHeader
 from PmuLookupTable
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Rhys Lloyd" <krakow20@gmail.com>, <dakr@kernel.org>
References: <20250714104322.100511-1-krakow20@gmail.com>
 <20250714104322.100511-2-krakow20@gmail.com>
In-Reply-To: <20250714104322.100511-2-krakow20@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UzVGQm4wWkRTa3RrdGdwd2hYQ1hXOFBWcTIwYzV4S0htSmZXbjN1UTg3a0RD?=
 =?utf-8?B?ZHR3WHFzd01NNE1JL2pnZmxacngwTnpDeGlNRmpvcUtJUTVwZ1ZZVTZRY0E5?=
 =?utf-8?B?RW1NMUNpeHordjhqRzd4RVpzZUZYeGpjSGNTQVVLUXdDdmdpVTVIQWRQUEo3?=
 =?utf-8?B?WmpXUTVKZllkRzFSd0M1ZUFkZkFSMURHMVd2S2IxTkdxaXFQWVVKYTNPWGMy?=
 =?utf-8?B?dTVaOGFnTzdpeUtjaG9oQmo0ZXJzN1c5a1VqOXNDeHEyUkJDWFd0Z3FWWmlC?=
 =?utf-8?B?a0NQZm02WklzNW4zT2thVmhIL24zZ2gvcWdJQ1BUeFRveG00MFJOQUd1WHFZ?=
 =?utf-8?B?a1NySkhhOC9MVFZDNUdsb0lwcHZsQ2lTK29WNFhsRktEMWh1OTRvejdwT0Y3?=
 =?utf-8?B?SlJyRVhTUG1mbW8xTmNHcTBoSTMwV3VtV0NvUFVyRE5pTURlaDFORkU5R0la?=
 =?utf-8?B?by9WaWZ0bHFwZDRkSG1ZUVV3RmxLTGt4Y3RPWmE2OHlnRXpIbU5vL08rU1Nw?=
 =?utf-8?B?UkdhY091OE1NdkJZcjE4VHBwWDc1QmpzOG8wN0YvUGdIQVhZaWFWY3FFWk5B?=
 =?utf-8?B?dkIwL1VvQjlIN1R1ak9oVUs4bmlrR1cxNVBmUThZRTFDVS94V1hRWitzdVhK?=
 =?utf-8?B?US9RVXNiZ0l6cFlxRXkwNWZ4TlhjYWNOWlBJUmVic1dXRnRNS2FnZ3ZNQ0Vj?=
 =?utf-8?B?NEZOSjhVNWk5N0RPTk8yc25LeUt6L3JKdFVoTC91ZFF3WkVCSkVYdVRncXJy?=
 =?utf-8?B?QUZ5RWxSb1oxbHhqOEtDUGJ4djJlU01xUksySzlUb3hMQm93VHI4V3pCa1Ro?=
 =?utf-8?B?ZXNWeEluWDNpREZXSnl6N2g5c3NWTW1XT2Y3UFF6V3p0UWJZc0lRZDYwK0Fs?=
 =?utf-8?B?WFI0dzF3OHl6b2F3dHNhV1F4dmpaNVpFUXZZdUdETmJXWnlUYlNKT2sydXZj?=
 =?utf-8?B?a2M0Rnh3OHRrc3lHaXJtRklSdWYyVXV6aGx2VDRJTEFvNFhSUWh4UVBZd0Yr?=
 =?utf-8?B?WkVlQ1NYYVhORlZDL0lBZ3BuemxiSEVlTVVHWEc2WXgvckkzU09iUUN3RHV3?=
 =?utf-8?B?OUJiNTBYQzRrMldkd1JyWUV6TUxqWGZJUTV3aStwNGdWdERsSmlONlRXNzJs?=
 =?utf-8?B?Z2JTZ3NJTWVWT3pVRTQ1NGx4U3VmWEp4TmhQcmJrSzJWT0M0c1ZuaWg0Ylc0?=
 =?utf-8?B?bGxiOU1weWx1WEFJUXJUN3pGK2cwcHN4a0ZTeGlHR1pCRjA2MHR0R3g2VXNJ?=
 =?utf-8?B?MGloWndzVWRhM1Z2ekhuL3RRcDlwR01HSlJPUnhWTE5Vd2dic200UXpvR3p4?=
 =?utf-8?B?RWoxQmIyc2ZjTGd4TFdwSVBiWkNLRjZHYVJMK0I0Q2plTC9FMmFXYllCVHFl?=
 =?utf-8?B?MHJ1OGJyMHlKMytJbDkxQWVSOUZzSFVpUTI5R0N1UFNXdzRoazNPaGpzYk5t?=
 =?utf-8?B?OW5PRHlMYkdONnZVdjh6V2V3Q1czdlVUcXJLczRkRW8wWGhFUSsvZi8vTU5J?=
 =?utf-8?B?b3JQSVBsb1kxeUhVSGF3UGRHaFVLazhXdWhQR1I0WVhrcjdGTnlwcXJBSHYz?=
 =?utf-8?B?TEVYOGwvTlhRTGtuZzY1L2ZiNmpteHpjZWxadnFIQnBuVU5BNFAwWmJ6QytH?=
 =?utf-8?B?ekFRVk5yaHA0Zm9IS0RPWlNnTVhqSGtVRVJOZUV0eGFKSEswM2UvNGZKNml3?=
 =?utf-8?B?aDQrRC9wT2ZpcVhTWC83bEdVbHJTMkcvS3V1UmFXcmxlUWxRaE1FeGJTQndO?=
 =?utf-8?B?TDE5OFhkcCttU25xYzhEUTJHdnRwK0FhTDlnWXZhTkFhdDFZOHB1WHVQcHF1?=
 =?utf-8?B?Y3prVWhPYTV6b1NmL3Y3SVR0dWc2U1hBT2E4T1VFV2I0WWJCWDVmakR3Rkkx?=
 =?utf-8?B?Skx6TGptVi9IVHEvM1JicTlNeWRoOFpEVHNsT3U1MHQzMDNTSW8zYVQrRkJW?=
 =?utf-8?B?V1lkeS9sMFhFWGI0ZnlBaG9tL3ZvSTBqb1RBZHFpN0M3c2p4S1NIc29xcy9M?=
 =?utf-8?B?eldYSnpqdHFhdTE2SFB4Y3dWbnRweG9xTTNUR2V3WDZROE9HTjUwcDZ3eS91?=
 =?utf-8?B?d1VlSncxNXdGN3lQNWI4NWpLa2Zlb0FSeG10b2JVSWZRbmV3UG1rRVpXR1l4?=
 =?utf-8?B?Unc3NWttMFhxWkhCM3pCaVBicjhFZnJrS1NKMDlzMVYxNnVOdzJ5MmlER3cr?=
 =?utf-8?Q?HVZW3wOhIhfblDBS/k7Lp5C5EsmwoVxgAkXJDlZmBP2s?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf5b7671-5cc5-4cee-1210-08ddc409cc1e
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2025 01:40:51.6720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sk0fod9qa6ADNnfuEbc6IpfKK3ifGvCnmWSP3gpWth/7Xwr+PhvwEGM2kVbJI9jv0gv+8E3k0j41Bve0gBNSSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5795

On Mon Jul 14, 2025 at 7:43 PM JST, Rhys Lloyd wrote:
> Separating the header allows the use of `size_of::<PmuLookupTableHeader>(=
)`
> instead of the magic number 4.
>
> Signed-off-by: Rhys Lloyd <krakow20@gmail.com>
> ---
>  drivers/gpu/nova-core/vbios.rs | 56 +++++++++++++++++++++-------------
>  1 file changed, 35 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios=
.rs
> index 663fc50e8b66..20011c5c9bbc 100644
> --- a/drivers/gpu/nova-core/vbios.rs
> +++ b/drivers/gpu/nova-core/vbios.rs
> @@ -889,6 +889,32 @@ fn try_from(base: BiosImageBase) -> Result<Self> {
>      }
>  }
> =20
> +/// The [`PmuLookupTableHeader`] structure is header information for [`P=
muLookupTable`].
> +///
> +/// See the [`PmuLookupTable`] description for more information.
> +#[expect(dead_code)]
> +struct PmuLookupTableHeader {
> +    version: u8,
> +    header_len: u8,
> +    entry_len: u8,
> +    entry_count: u8,
> +}
> +
> +impl PmuLookupTableHeader {

Can you add a=20

  // TODO[TRSM]: use FromBytes::from_bytes when it becomes available.

as ultimately that's what we want to do.

(we are using these markers to keep track of tasks to complete as Rust
features land, see Documentation/gpu/nova/core/todo.rst)

> +    fn new(data: &[u8]) -> Result<Self> {
> +        if data.len() < core::mem::size_of::<Self>() {
> +            return Err(EINVAL);
> +        }
> +
> +        Ok(PmuLookupTableHeader {
> +            version: data[0],

How about making `PmuLookupTableHeader` `#[repr(C)]` and using
`offset_of!`? This will also set the stage for the transition to using
`FromBytes::from_bytes`.