Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 853CBCCD185 for ; Fri, 10 Oct 2025 12:40:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C87278410C; Fri, 10 Oct 2025 14:40:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="QiF7UvRG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 21B018419E; Fri, 10 Oct 2025 14:40:56 +0200 (CEST) Received: from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CC05E83F91 for ; Fri, 10 Oct 2025 14:40:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=anshuld@ti.com Received: from lelvem-sh02.itg.ti.com ([10.180.78.226]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTP id 59ACemtu316769; Fri, 10 Oct 2025 07:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1760100048; bh=rvzNxLh2yMzeaJuyTd04RPaWpZRLcihIaquzoaGbRQk=; h=Date:CC:Subject:From:To:References:In-Reply-To; b=QiF7UvRGR+hwo091WORq/M33aqz77gM2EL62TVnzOTyLG0LDK4P2sR8tSYs/EiNTN hLGM0LAiePxLZaXNu3iK2OP6igmsL1+L67/DjPVYGqW2mChzRu3jKlaXXR4KcqVJFy ohk7CNJS1HqrJjOye70/TDeCWeSLX1mqMGf4PhRE= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelvem-sh02.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 59ACemfJ1676613 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Fri, 10 Oct 2025 07:40:48 -0500 Received: from DLEE201.ent.ti.com (157.170.170.76) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Fri, 10 Oct 2025 07:40:47 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Fri, 10 Oct 2025 07:40:48 -0500 Received: from localhost (dhcp-172-24-233-105.dhcp.ti.com [172.24.233.105]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 59ACek9q1883808; Fri, 10 Oct 2025 07:40:47 -0500 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Date: Fri, 10 Oct 2025 18:10:46 +0530 Message-ID: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH v9 05/11] arm: armv8: mmu: add mem_map_fix_dram_banks From: Anshul Dalal To: Ilias Apalodimas , Anshul Dalal X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251010055340.2574743-1-anshuld@ti.com> <20251010055340.2574743-6-anshuld@ti.com> In-Reply-To: X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri Oct 10, 2025 at 5:29 PM IST, Ilias Apalodimas wrote: > On Fri, 10 Oct 2025 at 08:53, Anshul Dalal wrote: >> >> For armv8, U-Boot uses a static map defined as 'mem_map' for configuring >> the MMU as part of mmu_setup. >> >> But since the exact configuration of memory banks might not be known at >> build time, many platforms such as imx9, versal2 etc. utilize >> gd->bd->bi_dram to configure the static map at runtime. >> >> Therefore this patch adds a new API mem_map_fix_dram_banks that modifies >> the static map in a similar way. Allowing the caller to map all dram >> banks by just passing the index to last entry in their mem_map and it's >> length. >> >> Reviewed-by: Dhruva Gole >> Signed-off-by: Anshul Dalal >> Tested-by: Wadim Egorov >> --- >> arch/arm/cpu/armv8/cache_v8.c | 28 ++++++++++++++++++++++++++++ >> arch/arm/include/asm/armv8/mmu.h | 10 ++++++++++ >> 2 files changed, 38 insertions(+) >> >> diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8= .c >> index 74c78cb2fb0..cdf17d5f396 100644 >> --- a/arch/arm/cpu/armv8/cache_v8.c >> +++ b/arch/arm/cpu/armv8/cache_v8.c >> @@ -58,6 +58,34 @@ static int get_effective_el(void) >> return el; >> } >> >> +int mem_map_fix_dram_banks(unsigned int index, unsigned int len, u64 at= trs) > > Nit, but perhaps mem_map_from_dram_banks() is a better name? > Yeah, that's more descriptive of the actual functionality. Will fix in the next revision. >> +{ >> + unsigned int i; >> + int ret =3D fdtdec_setup_memory_banksize(); >> + >> + if (ret) { >> + printf("%s: Failed to setup dram banks\n", __func__); >> + return ret; > > We already include , so I prefer using log_err() etc. > Sounds good to me, will fix. Thanks for the review! Anshul