From: Masaki Kanno Subject: Re: [PATCH] Check for valid CPU_CAP value when creating(constructing) new domain Date: Mon, 30 Mar 2009 16:52:13 +0900 Message-ID: References: <49D069FB.1020401@redhat.com> <49D0764E.60300@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-gbBtuvBK2ibKA41uOdyE7" Return-path: In-Reply-To: <49D0764E.60300@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Michal Novotny Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-gbBtuvBK2ibKA41uOdyE7 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Description: Mail message body Hi Michal, I have added the following fixes to your patch. - Check scheduler type - Replace tab-indent with space-indent How about the patch? Signed-off-by: Michal Novotny Signed-off-by: Masaki Kanno Best regards, Kan Mon, 30 Mar 2009 09:35:42 +0200, Michal Novotny wrote: >Hi Kan, >this is new version of my patch implementing check for both CPU_CAP and >CPU_WEIGHT and also considering int type for both (asserting it). > >Best regards, >Michal > >Masaki Kanno wrote: >> Hi Michal, >> >> Why does the patch implement only CPU_CAP? >> You should consider CPU_WEIGHT too. >> And you should consider scheduler types too. >> >> Best regards, >> Kan >> >> Mon, 30 Mar 2009 08:43:07 +0200, Michal Novotny wrote: >> >> >>> Hi, >>> >>> This patch implements check for valid cpu_cap value when creating domain ( >>> in range 0 to VcpuCount * 100 as when changing scheduler parameters). >>> >>> Signed-off-by: Michal Novotny >>> >>> >>> -------------------------------text/plain------------------------------- >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >>> >> >> > > >-------------------------------text/plain------------------------------- >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel --Boundary-gbBtuvBK2ibKA41uOdyE7 Content-Type: application/octet-stream; name="xen-valid-cap-value-when-creating-domain.patch" Content-Disposition: attachment; filename="xen-valid-cap-value-when-creating-domain.patch" Content-Transfer-Encoding: base64 ZGlmZiAtciAwYjEzZDk3ODc2MjIgdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW5J bmZvLnB5Ci0tLSBhL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5kRG9tYWluSW5mby5weQlU dWUgTWFyIDI0IDA2OjU1OjI5IDIwMDkgKzAwMDAKKysrIGIvdG9vbHMvcHl0aG9uL3hlbi94 ZW5kL1hlbmREb21haW5JbmZvLnB5CU1vbiBNYXIgMzAgMTY6NDA6MzMgMjAwOSArMDkwMApA QCAtMjMwNSw2ICsyMzA1LDIxIEBAIGNsYXNzIFhlbmREb21haW5JbmZvOgogICAgICAgICAj IFNldCBtYXhpbXVtIG51bWJlciBvZiB2Y3B1cyBpbiBkb21haW4KICAgICAgICAgeGMuZG9t YWluX21heF92Y3B1cyhzZWxmLmRvbWlkLCBpbnQoc2VsZi5pbmZvWydWQ1BVc19tYXgnXSkp CiAKKyAgICAgICAgIyBDaGVjayBmb3IgY3B1X3tjYXB8d2VpZ2h0fSB2YWxpZGl0eSBmb3Ig Y3JlZGl0IHNjaGVkdWxlcgorICAgICAgICBpZiBYZW5kTm9kZS5pbnN0YW5jZSgpLnhlbnNj aGVkaW5mbygpID09ICdjcmVkaXQnOgorICAgICAgICAgICAgY2FwID0gc2VsZi5nZXRDYXAo KQorICAgICAgICAgICAgd2VpZ2h0ID0gc2VsZi5nZXRXZWlnaHQoKQorCisgICAgICAgICAg ICBhc3NlcnQgdHlwZSh3ZWlnaHQpID09IGludAorICAgICAgICAgICAgYXNzZXJ0IHR5cGUo Y2FwKSA9PSBpbnQKKworICAgICAgICAgICAgaWYgd2VpZ2h0IDwgMSBvciB3ZWlnaHQgPiA2 NTUzNToKKyAgICAgICAgICAgICAgICByYWlzZSBWbUVycm9yKCJDcHUgd2VpZ2h0IG91dCBv ZiByYW5nZSwgdmFsaWQgdmFsdWVzIGFyZSB3aXRoaW4gcmFuZ2UgZnJvbSAxIHRvIDY1NTM1 IikKKworICAgICAgICAgICAgaWYgY2FwIDwgMCBvciBjYXAgPiBkb21pbmZvLmdldFZDcHVD b3VudCgpICogMTAwOgorICAgICAgICAgICAgICAgIHJhaXNlIFZtRXJyb3IoIkNwdSBjYXAg b3V0IG9mIHJhbmdlLCB2YWxpZCByYW5nZSBpcyBmcm9tIDAgdG8gJXMgZm9yIHNwZWNpZmll ZCBudW1iZXIgb2YgdmNwdXMiICUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChk b21pbmZvLmdldFZDcHVDb3VudCgpICogMTAwKSkKKwogICAgICAgICAjIFRlc3Qgd2hldGhl ciB0aGUgZGV2aWNlcyBjYW4gYmUgYXNzaWduZWQgd2l0aCBWVC1kCiAgICAgICAgIHBjaSA9 IHNlbGYuaW5mb1sicGxhdGZvcm0iXS5nZXQoInBjaSIpCiAgICAgICAgIHBjaV9zdHIgPSAn Jwo= --Boundary-gbBtuvBK2ibKA41uOdyE7 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-gbBtuvBK2ibKA41uOdyE7--