Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 18 Dec 2025 09:55:34 +0100
Message-Id: <DF17TCJPO9RT.2BK28ZOQSF9SN@kernel.org>
From: "Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [PATCH v3 1/9] rust: pci: add PCI device name method
Cc: "Gary Guo" <gary@garyguo.net>, <rust-for-linux@vger.kernel.org>, "John
 Hubbard" <jhubbard@nvidia.com>, "Joel Fernandes" <joelagnelf@nvidia.com>,
 "Alexandre Courbot" <acourbot@nvidia.com>, "Lyude Paul" <lyude@redhat.com>,
 <nouveau@lists.freedesktop.org>, "Alice Ryhl" <aliceryhl@google.com>, "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>
To: "Timur Tabi" <ttabi@nvidia.com>
References: <20251218013910.459045-1-ttabi@nvidia.com>
 <20251218013910.459045-2-ttabi@nvidia.com>
In-Reply-To: <20251218013910.459045-2-ttabi@nvidia.com>

On Thu Dec 18, 2025 at 2:39 AM CET, Timur Tabi wrote:
> +    #[inline]
> +    pub fn name(&self) -> &CStr {
> +        // SAFETY: By its type invariant `self.as_raw` is always a valid=
 pointer to a
> +        // `struct pci_dev`, which contains a `struct device dev` member=
.
> +        unsafe {
> +            let pci_dev =3D self.as_raw();
> +            let dev =3D &raw const (*pci_dev).dev;
> +
> +            // If init_name is set, use it; otherwise use the kobject na=
me
> +            let init_name =3D (*dev).init_name;
> +            let name_ptr =3D if !init_name.is_null() {
> +                init_name
> +            } else {
> +                (*dev).kobj.name
> +            };
> +
> +            CStr::from_char_ptr(name_ptr)
> +        }
> +    }
>  }

This does not belong into pci::Device, but device::Device.

Also, please do not open-code the init_name dance, please use dev_name() in=
stead.