Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 18 Dec 2025 20:14:22 +0900
Message-Id: <DF1ARMP4N97P.3SHVEW8B3EB1Z@nvidia.com>
Subject: Re: [PATCH v3 7/9] gpu: nova-core: implement BinaryWriter for
 LogBuffer
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Timur Tabi" <ttabi@nvidia.com>, "Gary Guo" <gary@garyguo.net>, "Danilo
 Krummrich" <dakr@kernel.org>, <rust-for-linux@vger.kernel.org>, "John
 Hubbard" <jhubbard@nvidia.com>, "Joel Fernandes" <joelagnelf@nvidia.com>,
 "Alexandre Courbot" <acourbot@nvidia.com>, "Lyude Paul" <lyude@redhat.com>,
 <nouveau@lists.freedesktop.org>
References: <20251218013910.459045-1-ttabi@nvidia.com>
 <20251218013910.459045-8-ttabi@nvidia.com>
In-Reply-To: <20251218013910.459045-8-ttabi@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cm5PMElNREdidVI0Q0xiK3lTSy9KSWkvbElia21kaFI3cElkTnI3N3YzREJZ?=
 =?utf-8?B?V3BFbGlmamM4UnJkd0pBM3dUamJzeE4wODVZdnoySExTVmRnU25EN1FNSWpJ?=
 =?utf-8?B?MGJodFJLRWhDZGZtcmRyMm4xK09MR1l1VXJTbEhhaEo1T2VNeGdtMmc2WUhu?=
 =?utf-8?B?Mi80cUw1L1huUDNFMGVCUlBtUFoyV3BoRUdDVjUxSURzMFFXVmdnT29qNk9V?=
 =?utf-8?B?dGpjWjZOSnpaL0o2YzZvVno3TysyajNLWCtFcHVHamRKUUdSZTVITzF1Z3JX?=
 =?utf-8?B?emlVZkhQclF0MEo1ZnNCbHBpZmgzVEI1MjluVGkvOCtlR1NtUVlBbzVzWjBW?=
 =?utf-8?B?WkhtUURkeEFoZXRWQ3hjc2JRNUh0bjdIM0ZKRC8rcWJZcjRmRjNRazNKT0d5?=
 =?utf-8?B?clZVb2ZkcGF1Q1MxdzU0b0t5WUlSdy8xcSt3M1NtR0UzSkQyNVJGNUFnM1FU?=
 =?utf-8?B?U2hqUHB2ejVjVUFCMTFmSTdZY2prVHNOR2xaclpUQnZuWU5ZYWxtaVVNSGVO?=
 =?utf-8?B?VDMvTUswa0dmeU9KRlhRemtHWThoRmw5YmZpNmZoUEZHT1Z4M20xcEg0c0I3?=
 =?utf-8?B?WThQU01WajdyL3VCaTJ4K0kzQmdtbVBnNnRjZ2JHVFdUOUxxbS9tejBPMzdM?=
 =?utf-8?B?TTJYVG02UU1IY3RXN0cvLytIRm5pamJEdXZwbVIzVXZYL2Y3V0daRFJHUFFz?=
 =?utf-8?B?YU5uYVI2TW1GNHY5WWRnLzdocTRIdGdJa0xyRGpxMU1rNWYzTlZab1NOaVhZ?=
 =?utf-8?B?OHprRnpQci9yQUs1bTRNd1V3czh5cVhqRlV3Q3dGR0plSXNFb0p2aW4yQ24x?=
 =?utf-8?B?bE1QSDR6alFVSmpaK09hYjAzZDlyQ3JpSEFuSnJuZjg1NWErQk54SVFCdGxv?=
 =?utf-8?B?NDQ3N09JdHNlYktkb1A3ckVEbExIU3Evd1lZaXpsdTgvUG96Vi81Kzd2Wnk5?=
 =?utf-8?B?TFFKK05FeFdLSEMzejdJTkRYdWQ5L2d0bjFhQjhEcm9rK2U2cEkwbktUMFVt?=
 =?utf-8?B?L25kNk9lNVB5NWdFNUVHTzRDQU0rUndWcGxBb0hUWFJPcTZQUVEvcFhPbS8r?=
 =?utf-8?B?NGx4TXRDR3g0QmhtQjRjRmd3K3NKcThOMU1ISk5QUjE3MTdhUWRrMVliS2I0?=
 =?utf-8?B?TEQvTFhUWHJnNDgvVXdZRHJISStEcGgxMVE4TlZNaFI4UmYyNUpyUzl6eFBp?=
 =?utf-8?B?M3VyckpzN0xNTlVscHhtZ3hhNDFOR2p3SlJDMmNwVEw2SFVHS0xCcUovc1la?=
 =?utf-8?B?R3lBWmtrTUxvY1JGN2xJWEJnUGhZQzlBN0hzNkZRclo4MG14UStoNk9EUzc3?=
 =?utf-8?B?MlBQclJUeWpxeEJadXNyNHZzcGIrUElNNmNiWjBLcjFzcXZ0QjRKK2dKV29z?=
 =?utf-8?B?NW5uNWt4dW45Q05Yc3l4V1BiWThGNjNFOFNvV1ZEQXNvaDh5ZjV2Z0JMR01X?=
 =?utf-8?B?TVc0M3V6VUF5OEVMOHdSRkt0a1ZjZTd6aS92TFRDMW9tRXlDV3ZjSGt4cndJ?=
 =?utf-8?B?a2M5K1Q1MUJJelc1dy82STlRckxIQVJBaVZHMFRNd0tCYXlhc2YyQ1Zmcmhr?=
 =?utf-8?B?MnhkYk1zTU1jUW1id0d1WjA5NnZhZkJORFNlRFZPeUlyNlp5aWh6S204emVT?=
 =?utf-8?B?N1lmeDllSnNOU2RmWGJmTCtJSUZoUjBjczIzSG9wNlpibEZmK2ZwT1EyT3VW?=
 =?utf-8?B?bVRsRUw3L3hxQlFFVC96aExkV0V4eUpjVTJoRkJSY29CTEpJTk16WEJDV3NV?=
 =?utf-8?B?OUNqQTlKOUE0OXBkcmdZbmNTblZpZjdSeW9QcWNxNVJudHVpQVVBVjJUR3Vx?=
 =?utf-8?B?RXBUVmtYT1hxYnpHcWg0MkZRVTVya1VXQjM4UkN5UHVjL2MwOGgvZjluRk1k?=
 =?utf-8?B?ZE16alNBdjF3MXl5aDNtZUZITjFVRW5ia010ZGlBa0FzN1ZVM0NPUy9Mc3dZ?=
 =?utf-8?B?VGNRcDU0eDlZcjV5ZUUwOVhGZXdrTkRHbFM3cWVJL0lUSlpLQitnOWVrSDJv?=
 =?utf-8?B?WXR1cG5YRmIxdXdGcFRPSnJQRWIvQ0V1TmlsWmU4WFNoS0pSZjBXNDYvaVQ0?=
 =?utf-8?B?WkJLanZZZk81TXdOd3pPVWY2ajVnSVkvRENCMDYxbHA2Q3M2ak1wUW9IdC9O?=
 =?utf-8?B?c25Xdlgyb2R4aDVyTm5sUVVraEJvQUpxZFplVzNCSzU5a25Ydk5BMUV5T0RQ?=
 =?utf-8?Q?5SBiYLIW4ylJSVEXl811FP2SMsSiCNJGuu6QNWDVBfZ+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe13a089-8b58-4336-a89d-08de3e269abf
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2025 11:14:26.1568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GNMyAb0kFSHooirYEP0YeMKdMPOb7ulGeJgwVCY90f7vMKSOHHoNyfFRhSVgnZS//EhTrQRc/1/07XDBkV+4zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8874

On Thu Dec 18, 2025 at 10:39 AM JST, Timur Tabi wrote:
> From: Alexandre Courbot <acourbot@nvidia.com>
>
> `LogBuffer` is the entity we ultimately want to dump through debugfs.
> Provide a simple implementation of `BinaryWriter` for it, albeit it
> might not cut the safety requirements.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
> ---
>  drivers/gpu/nova-core/gsp.rs | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/drivers/gpu/nova-core/gsp.rs b/drivers/gpu/nova-core/gsp.rs
> index fb6f74797178..860674dac31e 100644
> --- a/drivers/gpu/nova-core/gsp.rs
> +++ b/drivers/gpu/nova-core/gsp.rs
> @@ -3,6 +3,7 @@
>  mod boot;
> =20
>  use kernel::{
> +    debugfs,
>      device,
>      dma::{
>          CoherentAllocation,
> @@ -117,6 +118,29 @@ pub(crate) struct Gsp {
>      rmargs: CoherentAllocation<GspArgumentsCached>,
>  }
> =20
> +impl debugfs::BinaryWriter for LogBuffer {
> +    fn write_to_slice(
> +        &self,
> +        writer: &mut kernel::uaccess::UserSliceWriter,
> +        offset: &mut kernel::fs::file::Offset,
> +    ) -> Result<usize> {
> +        // SAFETY: This is a debug log buffer. GSP may write concurrentl=
y, so the
> +        // snapshot may contain partially-written entries. This is accep=
table for
> +        // debugging purposes - users should be aware logs may be slight=
ly garbled
> +        // if read while GSP is actively logging.
> +        let slice =3D unsafe { self.0.as_slice(0, self.0.count()) }?;
> +
> +        writer.write_slice_file(slice, offset)
> +    }
> +}
> +
> +// SAFETY: `LogBuffer` only provides shared access to the underlying `Co=
herentAllocation`.
> +// GSP may write to the buffer concurrently regardless of CPU access, so=
 concurrent reads
> +// from multiple CPU threads do not introduce any additional races beyon=
d what already
> +// exists with the device. Reads may observe partially-written log entri=
es, which is
> +// acceptable for debug logging purposes.
> +unsafe impl Sync for LogBuffer {}
> +

Did I actually write all this? I don't have any recollection of
submitting such a patch (and the safety comments don't look like my
style).