Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795181033; b=XM4thS8yA2S2ndpfTw683Uip+E7Bmdv4r8kV9x4yJURgGWEqlXtsg4ROeHBTJdyBmabZ 9rA0BCNqgY7VQhequsK1BObxW25S83z12ucIex0Vmr+kEenWogrP322yw7ehXpdO6kVS4 pPdCdX+QaVjHB1x5qv+y7yMmk+2XjnuUsB+STtC4e3111IiZ/zNp+0FzjHk31EjrUTsG7 +SOyvUcT3eX3TklS9wBk/lygBB+sqcltTn4bFypsGHxHEBK+/3w3ZlpOeSkTR11lwCqLB nFM6U0uMjWZ49FoWBFfszFrnLtfF2yltoLqPFdR8AL9qSGsL+kuz0Yd1f1D8AHyfrtQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795181033; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject:X-Mailer: References:In-Reply-To; bh=U9t5C73ir3/3QySglAwAwVOJ69q66296+82EjWEvxrc=; b=nC69ENZLu1fM3B65ExZTEMTLYk7D8SHvEGX8K0m3u1pfiblxvjuqb0bk+TUr9Ob6LX3i bZo6Uk6VEcd9VHbXPdGZpXcqZ8Alh+3qE6Fdc3e1+Zo1focVLzrzGTtTRiHhe7wTv/Ox+ aGJTs4T5Dr1vy3mzHhJcoWTD8wGTYtZjN9k1d07KQ7VdM7m6ZSV2+CMSCmcHk9FcTnHGw x/+BucqVWr4iqwCVner6ibMjL9fzby6o2RJHOxGOW07hk7BxM+qJC0kdfjGCE4NIBcIbR mfiNY/nsFQa8y09WVCrDThi1e1+OCGSGvZ8yZdx4PEegJkzac2H1WA+7VhKGmy45TJg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Pg2c1J0Q; arc=none smtp.remote-ip=209.85.128.51 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981B860A261E for ; Fri, 20 Nov 2026 13:23:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 981B860A261E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Pg2c1J0Q Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a35ac4475dso6348895e9.2 for ; Fri, 20 Nov 2026 05:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795181031; x=1795785831; darn=lists.linux.dev; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=U9t5C73ir3/3QySglAwAwVOJ69q66296+82EjWEvxrc=; b=Pg2c1J0QcAdNwMMVBdoNBwOZgWeASog0U/+WXWRzEpQ61o3k9JmD+Vchr99Uz0YKW0 wp0zLMOYI3VD1zUZGIIFWVEj5kH4W2yrwJUXE10nlK8s5Bm+4RH7m0IC8rUCJmeQUt/x ZYtx0Z1FHD38JZ+KCs5JjbGex9ObyrMsQyGkCUqwex5s4RqlJ/XGIabrIlW9OXeSnKFu 9fGyC55LP3HZQyYOtWBbvkwpseFLnaU3OTWtIO/OSrx5DgF3OG2RkWP9tg5Gdt0miJZ9 3J94IPLEx4dRRTpwWSmf9Bo0ZCMRWz74jgRpTdALug0eVRHmWuSEKUeLGtphbXdkzpRf P7xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795181031; x=1795785831; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=U9t5C73ir3/3QySglAwAwVOJ69q66296+82EjWEvxrc=; b=mDlbCHUPy70n+3zEfQWoGzLy6FQdBA3PJidWExGewp88i11USVv5gDkfvfGjEE3JO1 ePwUOi970XHkzJVT8jH4NLIGqv/u7ZklqH95BtxU6UE0NsvxFZh6ThV4stWb+nsaKSVb lgB//QRiuEOyaZS2Pz+Grg+iVSmAub5sfHdW7g5B7W5T/lt6IEN6Bab45erJQM4NN7oV D0GQ/qJI0JsOMjfiJuzAM7E95zpBuoblGw3rIa0TTSckwMqt0cyIs5+RBOYnBVrNn6Bj 3meduZE7BGxD/pH4A6aXspZa5TV8aY5s17aor3Eeh1MpUIAGVpdZcEGDeZGYK3eSYMWo HUlA== X-Forwarded-Encrypted: i=1; AL+hErEcKeVVyhl/U/fO/Bepana9+Orh2wWeBhbgocfsLbctleMtt6zA0f2mRLzjECs+mzUD72ePbQ==@lists.linux.dev X-Gm-Message-State: APuU4Z+l0TLcKs5WaxacGvdybcXL/cNT0GY218VD3j5wVDsvrJGULJ+/ nYKPOE4HhEENB+1rMnAPGaWbw9+YDdOnbl5/Sopmmpf5CN4o/W7wvN7f X-Gm-Gg: AYBFou2eQ16JcCIb7R0n4vpFsq1L0FjxTnbwoOyjHooCisAkdlh2vQKyk9Cm8/djrK7 9fW+BAznH1YQYK5V2YT6LnvPCN0XOET9+C260/b1qF/go2fzt0AFLyQF28FGY7TFM4TM5hU+3A2 5SoM3iDJ/9nlhP24meLFKA+yZYTJWoqrYcaPgdbK5FDS+Q4+3NqiFlX2YCau1ywKiSaIAr/6Sz+ /Erkr3ZzbN1BRDzJczumIrWAUug9uHSA8Ok5rdY19nusqzWOFJyNbZK9LDRd6U2HZXUSTuQjKTW wS/LWKhbMVxD2kbm8BoGTp78FHHVSGIk3IitmU3eNuwHNO4PrwxZzHZpE02TTSMmjNyCic3ldbn Fw+L7kiEW5IFOCUyNWsSxZBtwlgBdpuWGnMNKdn1yASiWXvRryjW5Sr3h5fkxoevOQhKU+M4/VK QzUFtVubfzBDCG8Jdl2M1B8th4RjdKNcWS/0stwnDm0ZrbVrP5rdTB2Zf9JksLvB5FMtq7bcj1Q eV28TRm/I4dGXJcPpbhfR6au70o+Z2rjAwhNfReOCVvMrJw5vCGkCt7gQ+AskN8VCKGEuTRbirk pR8xw6AxK3QHm2uEJpxRu3H8TwRVkPXI1TLogGsTSXNu6bl3 X-Received: by 2002:a05:600c:3b83:b0:4b7:6b96:e431 with SMTP id 5b1f17b1804b1-4bb88822242mr75040685e9.28.1795181030668; Fri, 20 Nov 2026 05:23:50 -0800 (PST) Received: from localhost ([130.192.98.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab65cb41f4sm5518234f8f.7.2026.11.20.05.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2026 05:23:49 -0800 (PST) X-Mailing-List: exfat@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Fri, 20 Nov 2026 14:23:41 +0100 Message-Id: From: "koraynilay" To: "Amir Goldstein" , "koraynilay" Cc: =?utf-8?q?Pali_Roh=C3=A1r?= , "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , "Konstantin Komarov" , "Paulo Alcantara" , "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J . Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , , , , , , , , Subject: Re: [RFC PATCH v4 09/10] ksmbd: add provenance time (ptime) and map it to CreationTime X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> <20261115180343.576773-10-koray.fra@gmail.com> <20261119220936.mssmaixcorn2gzli@pali> In-Reply-To: --7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Nov 20, 2026 at 7:03 AM CET, Amir Goldstein wrote: > On Thu, Nov 19, 2026 at 11:25=E2=80=AFPM koraynilay = wrote: >> >> On Thu Nov 19, 2026 at 11:09 PM CET, Pali Roh=C3=A1r wrote: >> > On Thursday 19 November 2026 22:51:26 koraynilay wrote: >> >> On Thu Nov 19, 2026 at 6:34 PM CET, Amir Goldstein wrote: >> >> > On Sun, Nov 15, 2026 at 7:04=E2=80=AFPM koraynilay wrote: >> >> >> >> >> >> Implement provenance time (ptime) in ksmbd, as introduced in a >> >> >> previous commit ("vfs: add provenance time (ptime)"). >> >> >> >> >> >> Map it to SMB's CreationTime, making it settable by SMB clients. W= hen >> >> >> reporting CreationTime to clients, prioritize ptime over da.create= _time >> >> >> memorized in the user.DOSATTRIB xattr. >> >> > >> >> > That doesn't sound like the right thing to do. >> >> > >> >> > If the server stored a CreationTime that client had set, you cannot >> >> > override this. >> >> >> >> Ah, yes, but how would we handle older files which get a custom >> >> CreationTime both before (in the xattr) and after (in ptime) a kernel >> >> upgrade? >> > >> > Just to note that this problem is already there. ksmbd can export for >> > example ntfs filesystem on removable disk. And this removable disk can >> > be connected to Windows machine which will always only touch >> > CreationTime and ignores xattr DOSATTRIB. >> > >> >> > When the client sets CreationTime, the server can decide if it can = and wants >> >> > (may be a policy decision) to store CreationTime in PTIME and not s= tore >> >> > it in user.DOSATTRIB. >> >> >> >> To fix the above problem we should probably keep storing it in both >> >> ptime and the xattr though. >> > >> > IMHO for a long term solution it is better to not have duplicated >> > information in xattr. Because duplicated information are going to be >> > out-of-sync. Windows NTFS driver will not update xattr DOSATTRIB. >> >> Yeah, to avoid out-of-sync issues is why I made ksmbd prefer ptime over >> the xattr's CreationTime. >> >> > >> > For me it looks like that this needs some policy / configuration >> > decision done by user. We do not know if the user will replug that dis= k >> > also to Windows NTFS driver (and then those xattr DOSATTRIB could caus= e >> > out-of-sync issues) or will only use it from Linux or Samba and then >> > xattr DOSATTRIB is probably fine. >> >> I'm not sure if this is the best solution, it doesn't feel too right >> to me, but maybe there isn't a better one. >> > > If you ask me, this is not your problem and I agree with Pali that > this is a policy decision. > > I would not include this patch at all in the series if I were you. > Maybe as a demo user, but you could just as well include a demo > user application. Ah, ok, fair. > The nfsd user is a simpler demo, so as long as the nfsd maintainers > are on the same page wrt the mutable btime plan, you could include > it in your series. > > The problem you raise with DOSATTRIB xattr is similar to the problems > that Chuck raised for ptime vs. btime as the source of FATTR4_TIME_CREATE Ah right, I can see the parallel, tho before the ptime change you couldn't modify the creation time at all from linux with nfsd, so in that case unless a user manually changed it after a kernel upgrade, it wouldn't have this desync problem (apart from a kernel downgrade). Thanks, koraynilay > Thanks, > Amir. --7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRJ2XvJtXGwULYEerQ0bnTtJTDoOAUCawBJ3gAKCRA0bnTtJTDo OJc/AQCn/pvK3+PSezucUXa1GtiKLjE7oMlXGStcJfzdnlWtcAD9GPZFH0ccIs4C afAlaO9nsoqLSUJ3Hk7qioPrnGVqrQM= =CBTM -----END PGP SIGNATURE----- --7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9--