Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C91A9C83F03 for ; Fri, 4 Jul 2025 15:25:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXiHi-00080Y-Dn; Fri, 04 Jul 2025 11:25:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXiHf-0007yt-Og for grub-devel@gnu.org; Fri, 04 Jul 2025 11:25:03 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXiHd-0001gz-1V for grub-devel@gnu.org; Fri, 04 Jul 2025 11:25:03 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 564F8p0X030047; Fri, 4 Jul 2025 15:24:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=xNvgVgfMyKAd8n3N5VReeFAUWqal6m gdJYb1bnLp4DI=; b=sXwfR78OYCbQdXvDUEmJEqf2PooNz+pwUeNUW4JlWdeWb/ t6mgJ087+bEn7jrBRGHivC6aPHIGdqz8/jbHGDlvh/Jh8j0tJGXyNbVRh3sQqcoA Gteh3X5AmUnkpO6ckl5Lz0pwVTbzDfMaIpc1Hpbc90Phx3nFUkkDO2sthAgi0Kul 8gSxrcHAmNlizTbnn88OShcT/dT0RyeRt6ZvR+zZeY6IJQNGS74xXMjW+bLVJ4ij HlUfg2kTPUrRyWhCBVbUtHfxeVExCjai30tZAO9VqXvJFc8uWO7/B3bIQk5AQW+T h1VBlXDIL5PHye5Uth3jC3f9zc6015QMAuE1cpJg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7ws2k6w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Jul 2025 15:24:58 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 564EXWjA032148; Fri, 4 Jul 2025 15:24:57 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47ju412jjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Jul 2025 15:24:57 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 564FOsXH56361320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 Jul 2025 15:24:54 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9540A2004E; Fri, 4 Jul 2025 15:24:54 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E840A20040; Fri, 4 Jul 2025 15:24:53 +0000 (GMT) Received: from smtpclient.apple (unknown [9.124.214.106]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 4 Jul 2025 15:24:53 +0000 (GMT) From: Sudhakar Kuppusamy Message-Id: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: [PATCH] arm64/xen: Use bool instead of int Date: Fri, 4 Jul 2025 20:54:42 +0530 In-Reply-To: Cc: The development of GNU GRUB To: Frediano Ziglio References: <20250704140516.352156-1-frediano.ziglio@cloud.com> <0D405704-A52D-41D7-B33A-1CC12FC078F7@linux.ibm.com> X-Mailer: Apple Mail (2.3826.600.51.1.1) X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=E/PNpbdl c=1 sm=1 tr=0 ts=6867f24a cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=Wb1JkmetP80A:10 a=I779YDaTAAAA:8 a=VnNF1IyMAAAA:8 a=mDV3o1hIAAAA:8 a=5020TpcIS0lU3vvQQL4A:9 a=QEXdDO2ut3YA:10 a=LSjSEjx7JilWiDzVtTsA:9 a=hnpVuIZdIXBb384h:21 a=_W_S_7VecoQA:10 a=lqcHg5cX4UMA:10 X-Proofpoint-GUID: ZLR4K4EetlTD08pXpwFBnP-Ji2j9w_d1 X-Proofpoint-ORIG-GUID: ZLR4K4EetlTD08pXpwFBnP-Ji2j9w_d1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA0MDExNiBTYWx0ZWRfXwzja4+10vbx3 32WEZE3AoRWqQCDjstEtorH/Z8vQx+djXaep++kp3RWwjNCfYQsmmJDrdrDtiDgGbgLv9y1GNfc hQXZKI9e6lxvCa1z7cen5xzKI+dk7OSCHLsOquCuJ7N60g0QyGpQXoRHxsakTFoqOeJako0VOLA O9RBGawrse4qVT8DoYYqRWFOARA3tNnNo+j2F9ozo+mTtOZnx9DjM5+26oTCRPT0Xi3X2HhgYIB JesSWSYCJVQH7bVSezZAw0LQfr0cSSSWSBNrLUjahYKZomzBO0v1RjYXfK45NRPX1S+McbaxXpr BZhUb6SD8GtFYqgccXRuiSgVeNtXjQUEWYTk9NorRlK0r82l2kOVjz8zml0rrbKojuzD5wVjDTd SB7ec1bOGhUwop+kVNkHQ9m1/EZwdpveF0wYkpAzAfhVX1Ajo/5SNuXsNCb2Ie2GeqVtY9BZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_06,2025-07-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 clxscore=1015 adultscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507040116 Received-SPF: pass client-ip=148.163.156.1; envelope-from=sudhakar@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.218, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Type: multipart/mixed; boundary="===============8683453273747637494==" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org --===============8683453273747637494== Content-Type: multipart/alternative; boundary="Apple-Mail=_E1E531BD-F33A-469A-8C53-75D060FC306B" --Apple-Mail=_E1E531BD-F33A-469A-8C53-75D060FC306B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 4 Jul 2025, at 8:48=E2=80=AFPM, Frediano Ziglio = wrote: >=20 > On Fri, Jul 4, 2025 at 4:13=E2=80=AFPM Sudhakar Kuppusamy > wrote: >>=20 >>=20 >>=20 >>> On 4 Jul 2025, at 7:35=E2=80=AFPM, Frediano Ziglio via Grub-devel = wrote: >>>=20 >>> More readable, could consume less space. >>>=20 >>> Signed-off-by: Frediano Ziglio >>> --- >>> grub-core/loader/arm64/xen_boot.c | 14 +++++++------- >>> 1 file changed, 7 insertions(+), 7 deletions(-) >>>=20 >>> diff --git a/grub-core/loader/arm64/xen_boot.c = b/grub-core/loader/arm64/xen_boot.c >>> index 731f1913a..8db1d9db0 100644 >>> --- a/grub-core/loader/arm64/xen_boot.c >>> +++ b/grub-core/loader/arm64/xen_boot.c >>> @@ -67,7 +67,7 @@ struct xen_boot_binary >>> { >>> struct xen_boot_binary *next; >>> struct xen_boot_binary **prev; >>> - int is_hypervisor; >>> + bool is_hypervisor; >>=20 >>=20 >> Something is off with indention here >>>=20 >>> grub_addr_t start; >>> grub_size_t size; >>> @@ -79,7 +79,7 @@ struct xen_boot_binary >>>=20 >>> static grub_dl_t my_mod; >>>=20 >>> -static int loaded; >>> +static bool loaded; >> Something is off with indention here >>>=20 >>> static struct xen_boot_binary *xen_hypervisor; >>> static struct xen_boot_binary *module_head; >>> @@ -306,7 +306,7 @@ all_binaries_unload (void) >>> static grub_err_t >>> xen_unload (void) >>> { >>> - loaded =3D 0; >>> + loaded =3D false; >>=20 >> Something is off with indention here >>=20 >>> all_binaries_unload (); >>> grub_fdt_unload (); >>> grub_dl_unref (my_mod); >>> @@ -410,7 +410,7 @@ grub_cmd_xen_module (grub_command_t cmd = __attribute__((unused)), >>> if (!module) >>> return grub_errno; >>>=20 >>> - module->is_hypervisor =3D 0; >>> + module->is_hypervisor =3D false; >>> module->align =3D 4096; >>>=20 >>> grub_dprintf ("xen_loader", "Init module and node info\n"); >>> @@ -466,7 +466,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd = __attribute__ ((unused)), >>> if (!xen_hypervisor) >>> return grub_errno; >>>=20 >>> - xen_hypervisor->is_hypervisor =3D 1; >>> + xen_hypervisor->is_hypervisor =3D true; >> Same here. >>> xen_hypervisor->align >>> =3D (grub_size_t) = lh.pe_image_header.optional_header.section_alignment; >>>=20 >>> @@ -474,7 +474,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd = __attribute__ ((unused)), >>> if (grub_errno =3D=3D GRUB_ERR_NONE) >>> { >>> grub_loader_set (xen_boot, xen_unload, 0); >>> - loaded =3D 1; >>> + loaded =3D true; >> Same here. >>> } >>>=20 >>> fail: >>> @@ -482,7 +482,7 @@ fail: >>> grub_file_close (file); >>> if (grub_errno !=3D GRUB_ERR_NONE) >>> { >>> - loaded =3D 0; >>> + loaded =3D false; >>=20 >> same here >>=20 >> Thanks, >> Sudhakar >>> all_binaries_unload (); >>> grub_dl_unref (my_mod); >>> } >=20 > None on my side. Are you sure it's not a question of your fonts? Thanks Frediano. It seems issue with fonts. Reviewed-by: Sudhakar Kuppusamy > >=20 > Frediano --Apple-Mail=_E1E531BD-F33A-469A-8C53-75D060FC306B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 4 Jul 2025, at 8:48=E2=80=AFPM, Frediano Ziglio = <frediano.ziglio@cloud.com> wrote:

On Fri, Jul 4, 2025 at = 4:13=E2=80=AFPM Sudhakar Kuppusamy
<sudhakar@linux.ibm.com> = wrote:



On 4 Jul 2025, at 7:35=E2=80=AFPM, Frediano Ziglio via = Grub-devel <grub-devel@gnu.org> wrote:

More readable, could = consume less space.

Signed-off-by: Frediano Ziglio = <frediano.ziglio@cloud.com>
---
grub-core/loader/arm64/xen_boo= t.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 = deletions(-)

diff --git a/grub-core/loader/arm64/xen_boot.c = b/grub-core/loader/arm64/xen_boot.c
index 731f1913a..8db1d9db0 = 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ = b/grub-core/loader/arm64/xen_boot.c
@@ -67,7 +67,7 @@ struct = xen_boot_binary
{
 struct xen_boot_binary *next;
=  struct xen_boot_binary **prev;
-  int is_hypervisor;
+ =  bool is_hypervisor;


Something is off with = indention here

 grub_addr_t = start;
 grub_size_t size;
@@ -79,7 +79,7 @@ struct = xen_boot_binary

static grub_dl_t my_mod;

-static int = loaded;
+static bool loaded;
Something is off with = indention here

static struct = xen_boot_binary *xen_hypervisor;
static struct xen_boot_binary = *module_head;
@@ -306,7 +306,7 @@ all_binaries_unload = (void)
static grub_err_t
xen_unload (void)
{
-  loaded = =3D 0;
+  loaded =3D false;

Something is off = with indention here

=  all_binaries_unload ();
 grub_fdt_unload ();
=  grub_dl_unref (my_mod);
@@ -410,7 +410,7 @@ grub_cmd_xen_module = (grub_command_t cmd __attribute__((unused)),
 if (!module)
=    return grub_errno;

- =  module->is_hypervisor =3D 0;
+ =  module->is_hypervisor =3D false;
 module->align =3D = 4096;

 grub_dprintf ("xen_loader", "Init module and node = info\n");
@@ -466,7 +466,7 @@ grub_cmd_xen_hypervisor (grub_command_t = cmd __attribute__ ((unused)),
 if (!xen_hypervisor)
=    return grub_errno;

- =  xen_hypervisor->is_hypervisor =3D 1;
+ =  xen_hypervisor->is_hypervisor =3D true;
Same = here.
 xen_hypervisor->align
=    =3D (grub_size_t) = lh.pe_image_header.optional_header.section_alignment;

@@ -474,7 = +474,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd __attribute__ = ((unused)),
 if (grub_errno =3D=3D GRUB_ERR_NONE)
=    {
     grub_loader_set = (xen_boot, xen_unload, 0);
-      loaded =3D = 1;
+      loaded =3D = true;
Same here.
=    }

fail:
@@ -482,7 +482,7 @@ fail:
=    grub_file_close (file);
 if (grub_errno !=3D = GRUB_ERR_NONE)
   {
- =      loaded =3D 0;
+ =      loaded =3D false;

same = here

Thanks,
Sudhakar
=      all_binaries_unload ();
=      grub_dl_unref (my_mod);
=    }

None on my side. = Are you sure it's not a question of your = fonts?

Thanks Frediano. = It seems issue with = fonts.


Reviewed-by: Sudhakar = Kuppusamy <sudhakar@linux.ibm.com>


Frediano




= --Apple-Mail=_E1E531BD-F33A-469A-8C53-75D060FC306B-- --===============8683453273747637494== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZl bCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK --===============8683453273747637494==--