From: janitor@sternwelten.at Subject: [patch 1/3] list_for_each_entry: fs-namespace.c Date: Sun, 31 Oct 2004 00:34:28 +0200 Message-ID: Cc: linux-fsdevel@vger.kernel.org, viro@math.psu.edu, janitor@sternwelten.at, domen@coderock.org Return-path: Received: from baikonur.stro.at ([213.239.196.228]:33738 "EHLO baikonur.stro.at") by vger.kernel.org with ESMTP id S261360AbUJ3Weh (ORCPT ); Sat, 30 Oct 2004 18:34:37 -0400 To: akpm@osdl.org Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Make code more readable with list_for_each_entry. Compile tested. Signed-off-by: Domen Puncer Signed-off-by: Maximilian Attems --- linux-2.6.10-rc1-max/fs/namespace.c | 4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -puN fs/namespace.c~list-for-each-entry-fs_namespace fs/namespace.c --- linux-2.6.10-rc1/fs/namespace.c~list-for-each-entry-fs_namespace 2004-10-24 17:04:05.000000000 +0200 +++ linux-2.6.10-rc1-max/fs/namespace.c 2004-10-24 17:04:05.000000000 +0200 @@ -537,7 +537,6 @@ lives_below_in_same_fs(struct dentry *d, static struct vfsmount *copy_tree(struct vfsmount *mnt, struct dentry *dentry) { struct vfsmount *res, *p, *q, *r, *s; - struct list_head *h; struct nameidata nd; res = q = clone_mnt(mnt, dentry); @@ -546,8 +545,7 @@ static struct vfsmount *copy_tree(struct q->mnt_mountpoint = mnt->mnt_mountpoint; p = mnt; - for (h = mnt->mnt_mounts.next; h != &mnt->mnt_mounts; h = h->next) { - r = list_entry(h, struct vfsmount, mnt_child); + list_for_each_entry(r, &mnt->mnt_mounts, mnt_child) { if (!lives_below_in_same_fs(r->mnt_mountpoint, dentry)) continue; _