From: hooanon05@yahoo.co.jp Subject: Re: [RFC] Union Mount: Readdir approaches Date: Thu, 13 Sep 2007 14:52:35 +0900 Message-ID: References: <20070907054618.GD1692@in.ibm.com> <200709130832.09330.a1426z@gawab.com> Cc: Jan Engelhardt , bharata@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, Jan Blunck , "Josef 'Jeff' Sipek" To: Al Boldi Return-path: Received: from vsmtp02.dti.ne.jp ([202.216.231.137]:37367 "EHLO vsmtp02.dti.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbXIMFxl (ORCPT ); Thu, 13 Sep 2007 01:53:41 -0400 In-Reply-To: <200709130832.09330.a1426z@gawab.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Al Boldi: > It turns out that the problem was this in dentry.c: ::: > Commenting the #if block makes it compile now. > > Works great too. Even performance wise. Needs more testing though. Thank you for your report and forwarding your original message. And I am glad that it is working for you. It seems that '#if ... #endif' in an 'unlikly' macro argument is bad coding. I don't know why my compiler and other users compiler didn't produce an error. Anyway, I'll fix such code. > You really need to post a cleaned up version for review and possible > inclusion into mainline. It definitely looks solid. I'll try in the future. Thanks Junjiro Okajima