From: hooanon05@yahoo.co.jp Subject: Re: [UNIONFS] 00/42 Unionfs and related patches review Date: Mon, 10 Dec 2007 12:20:20 +0900 Message-ID: References: <11972545353262-git-send-email-ezk@cs.sunysb.edu> Cc: hch@infradead.org, viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Erez Zadok Return-path: Received: from vsmtp01.dti.ne.jp ([202.216.231.136]:43091 "EHLO vsmtp01.dti.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbXLJDVQ (ORCPT ); Sun, 9 Dec 2007 22:21:16 -0500 In-Reply-To: <11972545353262-git-send-email-ezk@cs.sunysb.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Erez Zadok: > (1) Cache coherency: by far, the biggest concern had been around cache ::: > unionfs. The solution we have implemented is to compare the mtime/ctime of > upper/lower objects during revalidation (esp. of dentries); and if the lower > times are newer, we reconstruct the union object (drop the older objects, > and re-lookup them). This time-based cache-coherency works well and is ::: The resolution of mtime/ctime may be too low since some filesystems sets them in unit of a second, which means you cannot detect the changes made within a second. I think it is better to use inotify for every directory while it consumes a little more resources. Additionally, if you implement vm_operations instead of struggling along address_space_operations or VFS patches, in order to share the mmap-ed memory pages between lower inode and unionfs inode, then most of issues will be gone. You can see this approach and how it is working in http://aufs.sf.net (and get the source file from CVS). But I am afraid the approach sharing memory pages will not be avaiable for ecryptfs. Junjiro Okajima