Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521A526B74F for ; Fri, 8 Aug 2025 12:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754655454; cv=none; b=AhNaEE9uXdCXkbSCoBdze9SQu11WRbv6vK2+JdzyMhvKIhEm3A4C/J3YM38VtcGjMLS3sfOIO6afiFgHkBFZinRDOY9bc34yRJh7xLAU6EpANfbdVXlJ31ksQHXa2dRHdwMw5pVkDlMnJlGTgeDZG749cW2tQNXNofiT1faM2A0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754655454; c=relaxed/simple; bh=mpVwnsW7H7OYLDLHf1JvMHRIl7lPFPFEEY9Tcq3fBHE=; h=From:To:Cc:Subject:MIME-Version:Content-Disposition:Content-Type: Message-Id:Date; b=GKpJCyB90hpUD+buBv05UhLSTNSH2DghQIqtbD+Ub5JcX+NiMcxfbkN4TzwXYguBi4PkctMIsV1wvz0xTwSFN50z5dqG8ONx1/UWVVU9v5JOdut+/g6TCjqExTL244DIwuIlga19FBpeH2U3wdx+JMrgoGI72fNvBfbMnELY0tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=PakCq/0P; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="PakCq/0P" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dUde5XvOXmf2RTKh7B+1y5/eHwJoJtelhNB3+mdvsF0=; b=PakCq/0PE4evWx1HnXkJq2A2Xv mFxfci1awEsJ83kmoNA7/M81AME3hOmD2jlxlyLUsW8gXmtVNP7jaGEI2RJgmChS7/vfa+KLSDNno xaHpN28FwfKvAmwPxTdZFrPGxYQAlx6WLPuFO+k2CW8D0KpbfEdk+TFoF5xex+P/b1CkGb1X4/ng4 GGq9hlVAev7TKQQtEx80LJ/9RuQ/F7q63phLQYYpP/v04H2ti615cA0jLRU3Uqs0P4wP97uKSDXJa +gRwv1LVk5GAAtSoh+uQKdbyHDpIlcGwY4ZB59aQRPzpCmqR4VvK4AyToMxDgwVuXQeQCSgOqXxdh 3w4PT5dw==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:41678 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ukM2B-0007Zd-02; Fri, 08 Aug 2025 13:17:19 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ukM1S-0086qo-PC; Fri, 08 Aug 2025 13:16:34 +0100 From: "Russell King (Oracle)" To: Andrew Lunn , David Wu , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net v2] net: stmmac: rk: put the PHY clock on remove Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: Sender: Russell King Date: Fri, 08 Aug 2025 13:16:34 +0100 The PHY clock (bsp_priv->clk_phy) is obtained using of_clk_get(), which doesn't take part in the devm release. Therefore, when a device is unbound, this clock needs to be explicitly put. Fix this. Signed-off-by: Russell King (Oracle) --- Spotted this resource leak while making other changes to dwmac-rk. Would be great if the dwmac-rk maintainers can test it. v2: fix build error drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 79b92130a03f..f6687c2f30f6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1765,11 +1765,15 @@ static int rk_gmac_probe(struct platform_device *pdev) static void rk_gmac_remove(struct platform_device *pdev) { - struct rk_priv_data *bsp_priv = get_stmmac_bsp_priv(&pdev->dev); + struct stmmac_priv *priv = netdev_priv(platform_get_drvdata(pdev)); + struct rk_priv_data *bsp_priv = priv->plat->bsp_priv; stmmac_dvr_remove(&pdev->dev); rk_gmac_powerdown(bsp_priv); + + if (priv->plat->phy_node && bsp_priv->integrated_phy) + clk_put(bsp_priv->clk_phy); } #ifdef CONFIG_PM_SLEEP -- 2.30.2