From: Masaki Kanno Subject: [PATCH] Fix xm commands so that the Traceback does not occur Date: Wed, 14 Jun 2006 11:42:49 +0900 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-IGvuFsTqN9Zs8nvEh9Oe3" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-IGvuFsTqN9Zs8nvEh9Oe3 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Description: Mail message body Hi, When we tested xm commands, the xm commands occurred the Traceback. The following are the examples. # xm sched-sedf domUtemp -s xx Unexpected error: exceptions.ValueError Please report to xen-devel@lists.xensource.com Traceback (most recent call last): File "/usr/sbin/xm", line 10, in ? main.main(sys.argv) File "//usr/lib/python/xen/xm/main.py", line 1169, in main rc = cmd(args) File "//usr/lib/python/xen/xm/main.py", line 701, in xm_sched_sedf opts['slice'] = ms_to_ns(v) File "//usr/lib/python/xen/xm/main.py", line 665, in ms_to_ns return (float(val) / 0.000001) ValueError: invalid literal for float(): xx # xm vcpu-pin domUtemp x 1 Unexpected error: exceptions.ValueError Please report to xen-devel@lists.xensource.com Traceback (most recent call last): File "/usr/sbin/xm", line 10, in ? main.main(sys.argv) File "//usr/lib/python/xen/xm/main.py", line 1173, in main rc = cmd(args) File "//usr/lib/python/xen/xm/main.py", line 600, in xm_vcpu_pin vcpu = int(args[1]) ValueError: invalid literal for int(): x The cause of the Traceback are entering wrong xm commands. We suggest this patch so that the Traceback does not occur. Signed-off-by: Hiroyuki Yamamoto Signed-off-by: Masaki Kanno Best regards, Kan --Boundary-IGvuFsTqN9Zs8nvEh9Oe3 Content-Type: application/octet-stream; name="xm.patch" Content-Disposition: attachment; filename="xm.patch" Content-Transfer-Encoding: base64 ZGlmZiAtciBhYTIyOTg3MzkxMTIgdG9vbHMvcHl0aG9uL3hlbi94bS9tYWluLnB5Ci0tLSBh L3Rvb2xzL3B5dGhvbi94ZW4veG0vbWFpbi5weQlGcmkgSnVuIDA5IDEwOjQwOjMxIDIwMDYg LTA2MDAKKysrIGIvdG9vbHMvcHl0aG9uL3hlbi94bS9tYWluLnB5CU1vbiBKdW4gMTIgMjA6 NDA6MTMgMjAwNiArMDkwMApAQCAtNTk3LDggKzU5NywxNiBAQCBkZWYgeG1fdmNwdV9waW4o YXJncyk6CiAgICAgYXJnX2NoZWNrKGFyZ3MsICJ2Y3B1LXBpbiIsIDMpCiAKICAgICBkb20g ID0gYXJnc1swXQotICAgIHZjcHUgPSBpbnQoYXJnc1sxXSkKLSAgICBjcHVtYXAgPSBjcHVf bWFrZV9tYXAoYXJnc1syXSkKKyAgICB0cnk6CisgICAgICAgIHZjcHUgPSBpbnQoYXJnc1sx XSkKKyAgICBleGNlcHQgKFZhbHVlRXJyb3IsIE92ZXJmbG93RXJyb3IpOgorICAgICAgICBl cnIoJ0ludmFsaWQgYXJndW1lbnQ6ICVzJyAlIGFyZ3NbMV0pCisgICAgICAgIHN5cy5leGl0 KDEpCisgICAgdHJ5OgorICAgICAgICBjcHVtYXAgPSBjcHVfbWFrZV9tYXAoYXJnc1syXSkK KyAgICBleGNlcHQgKFZhbHVlRXJyb3IsIE92ZXJmbG93RXJyb3IpOgorICAgICAgICBlcnIo J0ludmFsaWQgYXJndW1lbnQ6ICVzJyAlIGFyZ3NbMl0pCisgICAgICAgIHN5cy5leGl0KDEp CiAgICAgCiAgICAgc2VydmVyLnhlbmQuZG9tYWluLnBpbmNwdShkb20sIHZjcHUsIGNwdW1h cCkKIApAQCAtNjA2LDcgKzYxNCwxMSBAQCBkZWYgeG1fbWVtX21heChhcmdzKToKICAgICBh cmdfY2hlY2soYXJncywgIm1lbS1tYXgiLCAyKQogCiAgICAgZG9tID0gYXJnc1swXQotICAg IG1lbSA9IGludF91bml0KGFyZ3NbMV0sICdtJykKKyAgICB0cnk6CisgICAgICAgIG1lbSA9 IGludF91bml0KGFyZ3NbMV0sICdtJykKKyAgICBleGNlcHQgKFZhbHVlRXJyb3IsIE92ZXJm bG93RXJyb3IpOgorICAgICAgICBlcnIoJ0ludmFsaWQgYXJndW1lbnQ6ICVzJyAlIGFyZ3Nb MV0pCisgICAgICAgIHN5cy5leGl0KDEpCiAKICAgICBzZXJ2ZXIueGVuZC5kb21haW4ubWF4 bWVtX3NldChkb20sIG1lbSkKICAgICAKQEAgLTYxNCwxNSArNjI2LDI1IEBAIGRlZiB4bV9t ZW1fc2V0KGFyZ3MpOgogICAgIGFyZ19jaGVjayhhcmdzLCAibWVtLXNldCIsIDIpCiAKICAg ICBkb20gPSBhcmdzWzBdCi0gICAgbWVtX3RhcmdldCA9IGludF91bml0KGFyZ3NbMV0sICdt JykKKyAgICB0cnk6CisgICAgICAgIG1lbV90YXJnZXQgPSBpbnRfdW5pdChhcmdzWzFdLCAn bScpCisgICAgZXhjZXB0IChWYWx1ZUVycm9yLCBPdmVyZmxvd0Vycm9yKToKKyAgICAgICAg ZXJyKCdJbnZhbGlkIGFyZ3VtZW50OiAlcycgJSBhcmdzWzFdKQorICAgICAgICBzeXMuZXhp dCgxKQogCiAgICAgc2VydmVyLnhlbmQuZG9tYWluLnNldE1lbW9yeVRhcmdldChkb20sIG1l bV90YXJnZXQpCiAgICAgCiBkZWYgeG1fdmNwdV9zZXQoYXJncyk6CiAgICAgYXJnX2NoZWNr KGFyZ3MsICJ2Y3B1LXNldCIsIDIpCi0gICAgCi0gICAgc2VydmVyLnhlbmQuZG9tYWluLnNl dFZDcHVDb3VudChhcmdzWzBdLCBpbnQoYXJnc1sxXSkpCi0KKworICAgIGRvbSA9IGFyZ3Nb MF0KKyAgICB0cnk6CisgICAgICAgIHZjcHVzID0gaW50KGFyZ3NbMV0pCisgICAgZXhjZXB0 IChWYWx1ZUVycm9yLCBPdmVyZmxvd0Vycm9yKToKKyAgICAgICAgZXJyKCdJbnZhbGlkIGFy Z3VtZW50OiAlcycgJSBhcmdzWzFdKQorICAgICAgICBzeXMuZXhpdCgxKQorCisgICAgc2Vy dmVyLnhlbmQuZG9tYWluLnNldFZDcHVDb3VudChkb20sIHZjcHVzKQogCiBkZWYgeG1fZGVz dHJveShhcmdzKToKICAgICBhcmdfY2hlY2soYXJncywgImRlc3Ryb3kiLCAxKQpAQCAtNjQ3 LDE0ICs2NjksMjcgQEAgZGVmIHhtX2RvbW5hbWUoYXJncyk6CiAKIGRlZiB4bV9zY2hlZF9i dnQoYXJncyk6CiAgICAgYXJnX2NoZWNrKGFyZ3MsICJzY2hlZC1idnQiLCA2KQorCisgICAg diA9IFtdCiAgICAgZG9tID0gYXJnc1swXQotICAgIHYgPSBtYXAobG9uZywgYXJnc1sxOjZd KQorICAgIGZvciBvIGluIHJhbmdlKDEsIDYpOgorICAgICAgICB0cnk6CisgICAgICAgICAg ICB2LmFwcGVuZChsb25nKGFyZ3Nbb10pKQorICAgICAgICBleGNlcHQgKFZhbHVlRXJyb3Is IE92ZXJmbG93RXJyb3IpOgorICAgICAgICAgICAgZXJyKCdJbnZhbGlkIGFyZ3VtZW50OiAl cycgJSBhcmdzW29dKQorICAgICAgICAgICAgc3lzLmV4aXQoMSkKKwogICAgIHNlcnZlci54 ZW5kLmRvbWFpbi5jcHVfYnZ0X3NldChkb20sICp2KQogCiBkZWYgeG1fc2NoZWRfYnZ0X2N0 eGFsbG93KGFyZ3MpOgogICAgIGFyZ19jaGVjayhhcmdzLCAic2NoZWQtYnZ0LWN0eGFsbG93 IiwgMSkKIAotICAgIHNsaWNlID0gaW50KGFyZ3NbMF0pCisgICAgdHJ5OgorICAgICAgICBz bGljZSA9IGludChhcmdzWzBdKQorICAgIGV4Y2VwdCAoVmFsdWVFcnJvciwgT3ZlcmZsb3dF cnJvcik6CisgICAgICAgIGVycignSW52YWxpZCBhcmd1bWVudDogJXMnICUgYXJnc1swXSkK KyAgICAgICAgc3lzLmV4aXQoMSkKKwogICAgIHNlcnZlci54ZW5kLm5vZGUuY3B1X2J2dF9z bGljZV9zZXQoc2xpY2UpCiAKIGRlZiB4bV9zY2hlZF9zZWRmKGFyZ3MpOgpAQCAtNjk1LDE2 ICs3MzAsMjAgQEAgZGVmIHhtX3NjaGVkX3NlZGYoYXJncyk6CiAgICAgCiAgICAgIyBjb252 ZXJ0IHRvIG5hbm9zZWNvbmRzIGlmIG5lZWRlZCAKICAgICBmb3IgKGssIHYpIGluIG9wdGlv bnM6Ci0gICAgICAgIGlmIGsgaW4gWyctcCcsICctLXBlcmlvZCddOgotICAgICAgICAgICAg b3B0c1sncGVyaW9kJ10gPSBtc190b19ucyh2KQotICAgICAgICBlbGlmIGsgaW4gWyctcycs ICctLXNsaWNlJ106Ci0gICAgICAgICAgICBvcHRzWydzbGljZSddID0gbXNfdG9fbnModikK LSAgICAgICAgZWxpZiBrIGluIFsnLWwnLCAnLS1sYXRlbmN5J106Ci0gICAgICAgICAgICBv cHRzWydsYXRlbmN5J10gPSBtc190b19ucyh2KQotICAgICAgICBlbGlmIGsgaW4gWyctZScs ICctLWV4dHJhdGltZSddOgotICAgICAgICAgICAgb3B0c1snZXh0cmF0aW1lJ10gPSB2Ci0g ICAgICAgIGVsaWYgayBpbiBbJy13JywgJy0td2VpZ2h0J106Ci0gICAgICAgICAgICBvcHRz Wyd3ZWlnaHQnXSA9IHYKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgaWYgayBpbiBbJy1w JywgJy0tcGVyaW9kJ106CisgICAgICAgICAgICAgICAgb3B0c1sncGVyaW9kJ10gPSBtc190 b19ucyh2KQorICAgICAgICAgICAgZWxpZiBrIGluIFsnLXMnLCAnLS1zbGljZSddOgorICAg ICAgICAgICAgICAgIG9wdHNbJ3NsaWNlJ10gPSBtc190b19ucyh2KQorICAgICAgICAgICAg ZWxpZiBrIGluIFsnLWwnLCAnLS1sYXRlbmN5J106CisgICAgICAgICAgICAgICAgb3B0c1sn bGF0ZW5jeSddID0gbXNfdG9fbnModikKKyAgICAgICAgICAgIGVsaWYgayBpbiBbJy1lJywg Jy0tZXh0cmF0aW1lJ106CisgICAgICAgICAgICAgICAgb3B0c1snZXh0cmF0aW1lJ10gPSBp bnQodikKKyAgICAgICAgICAgIGVsaWYgayBpbiBbJy13JywgJy0td2VpZ2h0J106CisgICAg ICAgICAgICAgICAgb3B0c1snd2VpZ2h0J10gPSBpbnQodikKKyAgICAgICAgZXhjZXB0IChW YWx1ZUVycm9yLCBPdmVyZmxvd0Vycm9yKToKKyAgICAgICAgICAgIGVycignaW52YWxpZCAl cyB2YWx1ZTogJXMnICUgKGssIHN0cih2KSkpCisgICAgICAgICAgICBzeXMuZXhpdCgxKQog CiAgICAgIyBwcmludCBoZWFkZXIgaWYgd2UgYXJlbid0IHNldHRpbmcgYW55IHBhcmFtZXRl cnMKICAgICBpZiBsZW4ob3B0cy5rZXlzKCkpID09IDA6CkBAIC03NTYsMTIgKzc5NSwxNiBA QCBkZWYgeG1fc2NoZWRfY3JlZGl0KGFyZ3MpOgogICAgIGNhcCA9IE5vbmUKIAogICAgIGZv ciBvLCBhIGluIG9wdHM6Ci0gICAgICAgIGlmIG8gPT0gIi1kIjoKLSAgICAgICAgICAgIGRv bWFpbiA9IGEKLSAgICAgICAgZWxpZiBvID09ICItdyI6Ci0gICAgICAgICAgICB3ZWlnaHQg PSBpbnQoYSkKLSAgICAgICAgZWxpZiBvID09ICItYyI6Ci0gICAgICAgICAgICBjYXAgPSBp bnQoYSk7CisgICAgICAgIHRyeToKKyAgICAgICAgICAgIGlmIG8gPT0gIi1kIjoKKyAgICAg ICAgICAgICAgICBkb21haW4gPSBhCisgICAgICAgICAgICBlbGlmIG8gPT0gIi13IjoKKyAg ICAgICAgICAgICAgICB3ZWlnaHQgPSBpbnQoYSkKKyAgICAgICAgICAgIGVsaWYgbyA9PSAi LWMiOgorICAgICAgICAgICAgICAgIGNhcCA9IGludChhKQorICAgICAgICBleGNlcHQgKFZh bHVlRXJyb3IsIE92ZXJmbG93RXJyb3IpOgorICAgICAgICAgICAgZXJyKCdpbnZhbGlkICVz IHZhbHVlOiAlcycgJSAobywgc3RyKGEpKSkKKyAgICAgICAgICAgIHN5cy5leGl0KDEpCiAK ICAgICBpZiBkb21haW4gaXMgTm9uZToKICAgICAgICAgIyBwbGFjZSBob2xkZXIgZm9yIHN5 c3RlbS13aWRlIHNjaGVkdWxlciBwYXJhbWV0ZXJzCkBAIC03NzYsOSArODE5LDkgQEAgZGVm IHhtX3NjaGVkX2NyZWRpdChhcmdzKToKICAgICAgICAgaWYgY2FwIGlzIE5vbmU6CiAgICAg ICAgICAgICBjYXAgPSBpbnQofjApCiAKLSAgICAgICAgZXJyID0gc2VydmVyLnhlbmQuZG9t YWluLnNjaGVkX2NyZWRpdF9zZXQoZG9tYWluLCB3ZWlnaHQsIGNhcCkKLSAgICAgICAgaWYg ZXJyICE9IDA6Ci0gICAgICAgICAgICBwcmludCBlcnIKKyAgICAgICAgZXJyb3IgPSBzZXJ2 ZXIueGVuZC5kb21haW4uc2NoZWRfY3JlZGl0X3NldChkb21haW4sIHdlaWdodCwgY2FwKQor ICAgICAgICBpZiBlcnJvciAhPSAwOgorICAgICAgICAgICAgcHJpbnQgZXJyb3IKIAogZGVm IHhtX2luZm8oYXJncyk6CiAgICAgYXJnX2NoZWNrKGFyZ3MsICJpbmZvIiwgMCkK --Boundary-IGvuFsTqN9Zs8nvEh9Oe3 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-IGvuFsTqN9Zs8nvEh9Oe3--