From: Masami Watanabe Subject: Re: [PATCH][VNC Auth] Fix qemu-dm becomes defunct when rebooting hvm domain Date: Mon, 30 Oct 2006 21:29:27 +0900 Message-ID: References: <20061027163942.GM32556@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20061027163942.GM32556@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" , Keir Fraser Cc: Ian Pratt , Anthony Liguori , xen-devel@lists.xensource.com, masami.watanabe@jp.fujitsu.com, "Zheng, Jeff" List-Id: xen-devel@lists.xenproject.org Hi all, I am sorry for the delayed response. On Fri, 27 Oct 2006 17:39:42 +0100, Daniel P. Berrange wrote: > Not sure why qemu would do defunct though - if the vncpasswd is not set > in xenstore, it ought to have just fallen back to no-password auth. Yes. Thanks Dan. On Fri, Oct 27, 2006 at 05:16:57PM +0100, Keir Fraser wrote: > That would mean that you=B9d fall back to the default VNC password though= , > right? Why would it cause qemu to fail to restart and become a defunct > process? Thanks Keir, for your correction. Please refer to the following for accurate processing. - When qemu-dm start, qemu-dm is sure to need vncpasswd in xenstore. main()@vl.c -> xenstore_read_vncpasswd()@xenstore.c Null string vncpasswd is allowed. but non vncpasswd is not allowed. - If config.remove() in image.py, vncpasswd is not preserved in xend. When rebooting guest domain, xend cannot pass qemu-dm vncpasswd. - When vncpasswd cannot be read from xenstore, qemu-dm is exit(1). As a result, qemu-dm becomes defunct process. Best regards, Masami On Fri, 27 Oct 2006 17:39:42 +0100, Daniel P. Berrange wrote: > On Fri, Oct 27, 2006 at 05:16:57PM +0100, Keir Fraser wrote: > > On 25/10/06 11:07 pm, "Masami Watanabe" > > wrote: > > > > > Sorry, I should not have removed infomation on xend. > > > > > > image.py, line 399, in configVNC > > > config.remove(['vncpasswd', vncpasswd_vmconfig]) > > > > > > When vncpasswd is removed, qemu-dm cannot be started in reboot of hvm= domain. > > > Because necessary information disappears. > > > It cannot be helped though information in config list remains in xens= tore. > > > > > > This patch corrects above. > > > > That would mean that you=B9d fall back to the default VNC password thou= gh, > > right? Why would it cause qemu to fail to restart and become a defunct > > process? > > No, it looks correct to me - we were scrubbing the vncpassword from the > guest config after using it, so that it didn't appear in the SXPR data > with doing 'xm list --long' etc. But turns out we do need the password > later on after all, so we can't scrub it completely. Perhaps we just need > to scrub it out on the fly when talking to XM & other apps instead - i've > already been working on a patch to scrub it out when loggin the guest > data to /var/log/xen/xend.log. > > This 'config.remove' thing also impacted my equivalent vncpassword patche= s > for the paravirt framebuffer, because it meant when you do a save/restore > or a migrate, and started the VNC daemon it no longer found a password. > > Not sure why qemu would do defunct though - if the vncpasswd is not set > in xenstore, it ought to have just fallen back to no-password auth. > > Dan. > -- > |=3D- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 24= 96 -=3D| > |=3D- Perl modules: http://search.cpan.org/~danberr/ = -=3D| > |=3D- Projects: http://freshmeat.net/~danielpb/ = -=3D| > |=3D- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 950= 5 -=3D|