From: Chaitanya Patti Subject: Is a NULL check missing in nfs_lookup? Date: Thu, 4 Jan 2007 19:00:52 -0500 (EST) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from sbcs.sunysb.edu ([130.245.1.15]:44700 "EHLO sbcs.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965101AbXAEAUq (ORCPT ); Thu, 4 Jan 2007 19:20:46 -0500 Received: from compserv1 (compserv1 [130.245.1.44]) by sbcs.cs.sunysb.edu (8.13.6/8.12.11) with ESMTP id l0500pJI020847 for ; Thu, 4 Jan 2007 19:00:51 -0500 (EST) To: linux-fsdevel@vger.kernel.org Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hello everyone, In the function nfs_lookup in nfs/dir.c , the following line (line # 926): error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr); uses `nd' without having checked if it is NULL. Is this correct? This is in kernel version 2.6.19.1 Can someone check this ? Thanks, Chaitanya.