Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB923C433DB for ; Tue, 5 Jan 2021 13:02:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A24D22ADF for ; Tue, 5 Jan 2021 13:02:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A24D22ADF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71F7689862; Tue, 5 Jan 2021 13:02:52 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 092A289862 for ; Tue, 5 Jan 2021 13:02:51 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E2CA22AAC; Tue, 5 Jan 2021 13:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609851770; bh=/Tnbq4FC5ordGqRMZzBmEF2707cpXLotVuL1pB4INEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b7A+HlihRW0BWkxuWeObIBnymtaP0ufAI6iZqP+I33dmJaItT4s02eE21hd20fF/X d/gLGOgVM5jXbgjwt3xldxp8Yx05uXAdpw5ayzs7kX/HEqtzXpXUB3oUcRe35cTc// 0LAxDBVV/TNR3PSOx4/g/7uEn2gJ4Mz3qDyRHQzw= Date: Tue, 5 Jan 2021 14:04:14 +0100 From: Greg Kroah-Hartman To: Rob Herring Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: References: <20210104230253.2805217-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210104230253.2805217-1-robh@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , netdev@vger.kernel.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > DT properties which can have multiple entries need to specify what the > entries are and define how many entries there can be. In the case of > only a single entry, just 'maxItems: 1' is sufficient. > > Add the missing entry constraints. These were found with a modified > meta-schema. Unfortunately, there are a few cases where the size > constraints are not defined such as common bindings, so the meta-schema > can't be part of the normal checks. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Thierry Reding > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: Jonathan Cameron > Cc: Dmitry Torokhov > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Mauro Carvalho Chehab > Cc: Chen-Yu Tsai > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Sebastian Reichel > Cc: Ohad Ben-Cohen > Cc: Bjorn Andersson > Cc: Greg Kroah-Hartman > Signed-off-by: Rob Herring > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > index 247ef00381ea..f76b25f7fc7a 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -83,6 +83,7 @@ properties: > Phandle of a companion. > > phys: > + maxItems: 1 > description: PHY specifier for the USB PHY > > phy-names: > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index 2178bcc401bc..8e2bd61f2075 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -71,6 +71,7 @@ properties: > Overrides the detected port count > > phys: > + maxItems: 1 > description: PHY specifier for the USB PHY > > phy-names: > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > index 678396eeeb78..f506225a4d57 100644 > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > @@ -40,7 +40,7 @@ properties: > - const: mc > > phys: > - description: PHY specifier for the USB PHY > + maxItems: 1 > > usb-role-switch: > type: boolean Any reason you dropped the description for this entry, but not the other ones above? > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > index 388245b91a55..adce36e48bc9 100644 > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > @@ -15,13 +15,14 @@ properties: > - const: ti,j721e-usb > > reg: > - description: module registers > + maxItems: 1 > > power-domains: > description: > PM domain provider node and an args specifier containing > the USB device id value. See, > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > + maxItems: 1 > > clocks: > description: Clock phandles to usb2_refclk and lpm_clk Same here, why remove the description? thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel