Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F66DC433DB for ; Wed, 6 Jan 2021 22:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B3C922BF5 for ; Wed, 6 Jan 2021 22:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbhAFWdz (ORCPT ); Wed, 6 Jan 2021 17:33:55 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53926 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbhAFWdy (ORCPT ); Wed, 6 Jan 2021 17:33:54 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kxHMZ-00GXBo-BU; Wed, 06 Jan 2021 23:33:07 +0100 Date: Wed, 6 Jan 2021 23:33:07 +0100 From: Andrew Lunn To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH next] net: dsa: print error on invalid port index Message-ID: References: <20210106090915.21439-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210106090915.21439-1-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 06, 2021 at 10:09:15AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > Looking for an -EINVAL all over the dsa code could take hours for > inexperienced DSA users. Following this argument, you should add dev_err() by every -EINVAL. > Signed-off-by: Rafał Miłecki Reviewed-by: Andrew Lunn Andrew