Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54305C433FE for ; Tue, 8 Dec 2020 11:03:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C91423AA9 for ; Tue, 8 Dec 2020 11:03:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729112AbgLHLDb (ORCPT ); Tue, 8 Dec 2020 06:03:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:53948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728803AbgLHLDb (ORCPT ); Tue, 8 Dec 2020 06:03:31 -0500 Date: Tue, 8 Dec 2020 12:03:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607425370; bh=KoBAYD75ab5A8cY8n7hzwo2KX/ro8UpNXKXRD0/i7VA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=oeOwRUF7q9gpPvGL9Y9/IIXMxiyHzH9RVGLvIFcXe02KKQkWM43MzazGky+atFDpo /lqHqEw5+25RKG1P9uNUas+SAKwabD1I5HdFYmJF9xbBldNLSk2pMBBEx8QHsZ6TOT vGF/14ntsNXfEwitvxG2EeUgxl7p1rXjJzecu36w= From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Jiri Slaby , "open list:SERIAL DRIVERS" , Hauke Mehrtens , bcm-kernel-feedback-list , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Arnd Bergmann Subject: Re: [PATCH] tty: serial: bcm63xx: allow building on ARM64 Message-ID: References: <20201125081352.25409-1-zajec5@gmail.com> <6b107933-9ab1-7c46-c383-ed39b71b4ecb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Dec 08, 2020 at 11:45:33AM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Wed, Nov 25, 2020 at 9:53 AM Greg Kroah-Hartman > wrote: > > On Wed, Nov 25, 2020 at 09:38:50AM +0100, Rafał Miłecki wrote: > > > On 25.11.2020 09:23, Greg Kroah-Hartman wrote: > > > > On Wed, Nov 25, 2020 at 09:13:52AM +0100, Rafał Miłecki wrote: > > > > > From: Rafał Miłecki > > > > > > > > > > Hardware supported by bcm63xx is also used by BCM4908 SoCs family that > > > > > is ARM64. > > > > > > > > > > Signed-off-by: Rafał Miłecki > > > > > --- > > > > > drivers/tty/serial/Kconfig | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > > > > > index 28f22e58639c..6907c5b17a0e 100644 > > > > > --- a/drivers/tty/serial/Kconfig > > > > > +++ b/drivers/tty/serial/Kconfig > > > > > @@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE > > > > > config SERIAL_BCM63XX > > > > > tristate "Broadcom BCM63xx/BCM33xx UART support" > > > > > select SERIAL_CORE > > > > > - depends on MIPS || ARM || COMPILE_TEST > > > > > + depends on MIPS || ARM || ARM64 || COMPILE_TEST > > Why not s/ARM64/ARCH_BCM4908/? > > > > > > > > > Why do we have an arch dependancy at all now? > > > > > > From my experience "depends" is often used to limit symbol visibility to > > > applicable platforms only. I don't think Broadcom has any x86, risc, etc. > > > platforms so it's useless there. > > > > > > As for testing driver compilation on unused arch-s I thought that's what > > > COMPILE_TEST is for. > > > > > > Am I wrong there? I'm afraid we don't have clear Documentation on that. > > > Please kindly point me to some info if I'm wrong. > > > > If COMPILE_TEST is working for this driver, then trying to restrict it > > to a specific arch is usually pointless and the arch dependency can be > > removed, keeping patches like this from having to be made over time to > > add it to new arches :) > > > > > > > + default ARCH_BCM4908 > > > > > > > > Really? I thought we were getting rid of these "ARCH_platform_type" of > > No we are not. Ok, I keep getting mixed signals here. > > > > things. That's what a defconfig file is for, right? > > FWIW, the arm64 defconfig file enables about everything, for all arm64 > platforms. Then why are there ARCH_platforms for arm64 systems? > > > I had to miss something, last time I checked Linus called defconfigs a > > > garbage and wanted to get rid of them: > > > https://lwn.net/Articles/391372/ > > > > > > There are also no platform defconfigs in arch/arm64/ at all. Should I > > > handle it with arch/arm64/Kconfig.platforms and "select SERIAL_BCM63XX"? > > > > I thought we were trying to get rid of arm64 "platforms" as well. My > > point being, why is this needed at all? > > To prevent asking the user about a driver that is completely useless for > the system(s) the user is compiling a kernel for. How do you "know" that given the huge number of different ip blocks in SoC systems these days? > Do you want to let distros compile all arm/arm64-only SoC drivers for x86, too? Sure, many have crossed over over the years and shown up there. But distro config owners are smarter than that, give them some credit :) thanks, greg k-h