Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3405FC63777 for ; Mon, 30 Nov 2020 20:55:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A50D52067C for ; Mon, 30 Nov 2020 20:55:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A50D52067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjqCn-0004YQ-Vz for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 15:55:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjqAA-0003nu-Vu; Mon, 30 Nov 2020 15:52:47 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:56791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjqA8-0004cL-LE; Mon, 30 Nov 2020 15:52:46 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AE595FF3; Mon, 30 Nov 2020 15:52:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 30 Nov 2020 15:52:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=F79go/MZkAN7Anj1eDGpuEOQXI5 VocU5TCgeuw2aoVM=; b=tCAUufVR1RVTgpz+ufI52flmC19tZ/hEIVrGqJUePbm u8lrYeF9B4KrHGzU8exVrOL9eB5fBDtg7DPocZv7ijr6Md3ZjPtAfv8zlLJnzwXs +2raSCitn8wO/19k2P+lowrShpkv2WUK1dPvMpM8umfs/1MLd8c+nI/UcBb9Kl0l iORM1gZFwy3FvtsUtlVEaGzH6jyFyiux6lou+Ub+pwT0eMyln14tsSY2OD05bDoN n+qMhIgFs2A9PA0OfuNm9siXjfdXW62W5doN+E2apkS62z5gCB1l7KcEspSA7q5A jEfv69+5GJ1pjmDs0I1Qti1Z+ErL0DJlLMZTxItzBTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=F79go/ MZkAN7Anj1eDGpuEOQXI5VocU5TCgeuw2aoVM=; b=bqOY58pYe0LV1Y6/O3MHB+ 4ehQeqx55D1sVVcCflycbuwZRJ9cxkZU52NHvc12Atg+w8TGg6LOYwUNQ2V+flWM w/u1ZzrDwzJKUmXp4sUaxF79kBhS7mCLhLRT81tyTGADZXSz+SW4y17BaO/iAYai cvEEq3P3EZ73IzF874QJD6xfKlj6c3bJSLzCHS1yxlgXmbr9KbpZJBAKBYnyP4ri ubQlq0pw3FEGN512PGbBQ2y6zMO6SxJs4XRDCvRhYMDsNFru0AEwuBomRUycOYyH XXv7dXVHqoApknWQjyx62E7zTKmV5pvfQp1TUUrHp0oNqOK78MvMhIODT7p/zgUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeitddgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvddu ffeknecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C08D3064AB0; Mon, 30 Nov 2020 15:52:38 -0500 (EST) Date: Mon, 30 Nov 2020 21:52:36 +0100 From: Klaus Jensen To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2] hw/nvme: Move NVMe emulation out of hw/block/ directory Message-ID: References: <20201130145238.2509405-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cP/ZZIHBA8WK+x4Q" Content-Disposition: inline In-Reply-To: <20201130145238.2509405-1-philmd@redhat.com> Received-SPF: pass client-ip=64.147.123.20; envelope-from=its@irrelevant.dk; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Keith Busch , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --cP/ZZIHBA8WK+x4Q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Nov 30 15:52, Philippe Mathieu-Daud=C3=A9 wrote: > As IDE used to be, NVMe emulation is becoming an active > subsystem. Move it into its own namespace. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > v2: Rebased after nvme-ns got merged in commit 8680d6e3646 > --- > meson.build | 1 + > hw/{block/nvme.h =3D> nvme/nvme-internal.h} | 4 +- > hw/{block =3D> nvme}/nvme-ns.h | 0 > hw/{block/nvme.c =3D> nvme/core.c} | 2 +- > hw/{block =3D> nvme}/nvme-ns.c | 0 > MAINTAINERS | 2 +- > hw/Kconfig | 1 + > hw/block/Kconfig | 5 - > hw/block/meson.build | 1 - > hw/block/trace-events | 132 --------------------- > hw/meson.build | 1 + > hw/nvme/Kconfig | 4 + > hw/nvme/meson.build | 1 + > hw/nvme/trace-events | 133 ++++++++++++++++++++++ > 14 files changed, 145 insertions(+), 142 deletions(-) > rename hw/{block/nvme.h =3D> nvme/nvme-internal.h} (98%) > rename hw/{block =3D> nvme}/nvme-ns.h (100%) > rename hw/{block/nvme.c =3D> nvme/core.c} (99%) > rename hw/{block =3D> nvme}/nvme-ns.c (100%) Would we want to consider renaming nvme-ns.c to namespace.c? And maybe also follow up with consolidating nvme-ns.h into nvme-internal.h? --cP/ZZIHBA8WK+x4Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAl/FW5MACgkQTeGvMW1P Den0xAf8DFs7sYB6OUNIR3ZGrZ8DYvKqD2xkCroQGPwZEeHtq5GMP6cz97P4Acbb WySMfXcG2PrInyS1+K20Ls/LO2SlQ8mpZegV7x4UMdBHXo97o/8at3oXhE8sX53E 9v3oHPxUYb/u1gj8spxuaeEnsowm93+E8t7t8vL8OgxLqKpQavevf0Cau01N8m95 PJdQIz0NO44vXwYCcVkUN/6YjVy6JY0vTPFqatME+fsnygz0N1N1fQidNLcCW2aA nlSqf1w10nOnQZJWdi8DGSH+V8n8PSGKr5fOcWz3ZsR479X7hkwEMBPOgH7B2S4+ dkTnu+5na6xVhZjFbxEkQ6KcGfNbdg== =yGI6 -----END PGP SIGNATURE----- --cP/ZZIHBA8WK+x4Q--