Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3E6C433FE for ; Fri, 4 Dec 2020 05:19:19 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EBC822573; Fri, 4 Dec 2020 05:19:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EBC822573 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kl3Uy-00083x-7s; Fri, 04 Dec 2020 05:19:16 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl3Ux-00083p-6m for linux-f2fs-devel@lists.sourceforge.net; Fri, 04 Dec 2020 05:19:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZcMp6lx+FxRyZw+uNwbn0Cpe82tf7rQHjfdMl+yvn2I=; b=axCd6ONqYCNDeaqHIHKgPpFq02 NVmKp/j6NpYVT0fEBIU1PIYNd/iCtpfVT3g993j5Yx3ceQ/P3BXKTKpXC8POIT+/UHpN2pmLKYJjI KNH5eIFV9Bi0A5eQZtzU1U/06hurmfdIquKj/Hoxpcp2JRMCrNr1nEurPMfMwPylTNws=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZcMp6lx+FxRyZw+uNwbn0Cpe82tf7rQHjfdMl+yvn2I=; b=QoIwONqH4CBVIefqKEhJpN8flE 1yC8RY6d0nCxY0wXDO9k3woz+WfVFDvBa3hGx85EnSqZvazUr5LlyyZhg+zlkMzzuY0qhfTBuqcmW qRQxQqaMSrwHQgR8l+i2nbMq5unr6h5tVG7/9DxLzzhrTw3f3CK15sXxGBY8EzpQO5oE=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kl3Un-00EUQ2-G8 for linux-f2fs-devel@lists.sourceforge.net; Fri, 04 Dec 2020 05:19:15 +0000 Date: Thu, 3 Dec 2020 21:18:53 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607059135; bh=NTtFOG1GQx90cr9hCi4Q6/ZGEbwo1wz4YjAws8quq+Y=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=KeJEBuIP38Tw8Wdzo5/eCldxIhwTUc8sNMSvPvgbFt2S20Y9dxy9kLd62M+gHvkxo O8HVGaq6anDcfW50A8aEF4n/ZpmXLzLoUc4Zzs7+lKhKhxMng0nuuL9adZeytp/OSB LyEAOjTfLbu3fhCdYgGoje7zBqi/3efX5GzhWskoDMWAJVlMbb0qhM8VBslu194Sma 4XmZXW8sf7Ysvsv2QL2KYcLZ1PynVMnTRL047LF4GgZFZMt/Wkszc3acv8bt1U89WP nPI79ftT1h9Au9Z6v+kyfAXWUKIEZfx99g53LYngTW0GWixkycvUpetG94nhsFCfTB A2njq7xqQhaGA== From: Eric Biggers To: Daeho Jeong Message-ID: References: <20201204005847.654074-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1kl3Un-00EUQ2-G8 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix race of pending_pages in decompression X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Dec 04, 2020 at 02:00:34PM +0900, Daeho Jeong wrote: > I think I don't understand how verity works. > Right after verity is enabled on a file, is the verity logic working > for the whole file data area? > Or it's just working for the data area which is updated after verity is enabled? > It's for the whole file. My point is just that if there is a bio that saw that verity isn't enabled yet when it started and therefore STEP_VERITY didn't get set in the bio_post_read_ctx (or the bio_post_read_ctx didn't get allocated due to one not being needed), then the filesystem shouldn't change its mind and try to verify the pages when the bio completes if verity happened to be enabled concurrently. It's too late for that bio. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel