Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9436CC61DA4 for ; Thu, 23 Feb 2023 03:28:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E50DC85A7F; Thu, 23 Feb 2023 04:28:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QPXFmDVC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FEF085AC6; Thu, 23 Feb 2023 04:28:22 +0100 (CET) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BD00E85A08 for ; Thu, 23 Feb 2023 04:28:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id w42so9707887qtc.2 for ; Wed, 22 Feb 2023 19:28:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7rdPJimZ0rJBTBhsaOMqK3+IQ5Ldt9DPKIx5UaqG06M=; b=QPXFmDVCjgBsvjZ63HdsbBP47JpEtmL8aRaNlgvX5u9g/rZNM40uatWQFymj5sdzmb goEzqT2QceRgQr/etqLa5Oe25KZkyLvCBzC9JotYl694K0w+kYQmu7aOIM9pZvBXv8w+ b/xTGFkYOq6pN3+5QXPJa4LQ9aJgnSynrx/5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7rdPJimZ0rJBTBhsaOMqK3+IQ5Ldt9DPKIx5UaqG06M=; b=rPW1aI1n28l5QyQEDBxy9yqPsZmIvXTIWjs9NpzFvHr1lQ/R2HK8MXCyiaMC9Ksh4X /W53EAF5KQOdr6o2gV1rsBa1+h0yanQgSF/bXYu54U44ly8R1rIKv+Pmf6FOaRy74b69 kgVC0lLtnT7GUEwoLmd62Yw5A3krJBhxrWeiMMlekSyTqmiRt6I6otZIq4YaoG7MwW8V QMkHC2fXVNlJfzaH0EUuj7PlYkSwvTjMrchi6JwfPytKK5FDHZmCm1P/og5azeqeRKLR OeDZUC88iBwDOTSr1+EazVN9ImCytWxwLF5Tw89hxa/qj0YtUYE9TSv4MkHaOLPotYVx B74Q== X-Gm-Message-State: AO0yUKUHo4pBRHgxhCfHVKvYNPr7Rw93l5ltB41jj2wsnyIBnF7fl7PX f9NxkQ1V3d8Vi1bV3a+wlSGjKA== X-Google-Smtp-Source: AK7set+h2um9rJpwl6HxFpWDC8IQcRly7VT1s2iH7jlOTNkmsMcB66fKwgQBFA66PFb11SEtZGY+iA== X-Received: by 2002:a05:622a:353:b0:3ba:3ac7:ccf1 with SMTP id r19-20020a05622a035300b003ba3ac7ccf1mr5517128qtw.58.1677122897410; Wed, 22 Feb 2023 19:28:17 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b87e-a945-7631-50d9.res6.spectrum.com. [2603:6081:7b00:6400:b87e:a945:7631:50d9]) by smtp.gmail.com with ESMTPSA id a30-20020aed279e000000b003bd01b232dbsm2954684qtd.43.2023.02.22.19.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 19:28:17 -0800 (PST) Date: Wed, 22 Feb 2023 22:28:15 -0500 From: Tom Rini To: "CHLI30@nuvoton.com" Cc: Tim Lee , "sjg@chromium.org" , "u-boot@lists.denx.de" Subject: Re: [PATCH v1 1/1] tools: env: use /run to store lockfile Message-ID: References: <20230210090539.1631-1-timlee660101@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CFpUGzo7LKmGH3bN" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --CFpUGzo7LKmGH3bN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 23, 2023 at 01:06:20AM +0000, CHLI30@nuvoton.com wrote: > Hi Tom, >=20 > Is this commit valuable to merge into u-boot upstream? > Thanks your reviewing, just ping this event friendly. Yes, I'll be putting this in next soon, thanks. >=20 > Best regards, > Tim >=20 > -----Original Message----- > From: Tom Rini > Sent: Friday, February 10, 2023 11:30 PM > To: Tim Lee > Cc: sjg@chromium.org; CS20 CHLi30 ; u-boot@lists.denx= =2Ede > Subject: Re: [PATCH v1 1/1] tools: env: use /run to store lockfile >=20 > On Fri, Feb 10, 2023 at 05:05:39PM +0800, Tim Lee wrote: >=20 > > According this issue https://github.com/ppp-project/ppp/issues/339. > > Eventually, the dt-utils changed lock directory to fix missing > > /var/lock directory error then make dt-utils can run normally. > > > > We also have a similar issue with these two utilities fw_printenv and > > fw_setenv will failed when the directory /var/lock is non-existent. > > > > We have a custom linux distribution built with yocto (OpenBMC) that > > use systemd and it deprecated the /var/lock directory. > > More discussion in systemd/systemd#15668. > > > > Thus, we sync with community's solution for uboot/tools/env utilities: > > The current location /var/lock is considered legacy (at least by system= d). > > Just use /run to store the lockfile and append the usual .lock suffix. > > > > Tested: > > Verified /run/lock is now present and fw_printenv can work in OpenBMC. > > > > Signed-off-by: Tim Lee >=20 > Reviewed-by: Tom Rini >=20 > -- > Tom > ________________________________ > ________________________________ > The privileged confidential information contained in this email is inten= ded for use only by the addressees as indicated by the original sender of t= his email. If you are not the addressee indicated in this email or are not = responsible for delivery of the email to such a person, please kindly reply= to the sender indicating this fact and delete all copies of it from your c= omputer and network server immediately. Your cooperation is highly apprecia= ted. It is advised that any unauthorized use of confidential information of= Nuvoton is strictly prohibited; and any information in this email irreleva= nt to the official business of Nuvoton shall be deemed as neither given nor= endorsed by Nuvoton. --=20 Tom --CFpUGzo7LKmGH3bN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP23UQACgkQFHw5/5Y0 tyzzIgv/Xbjui/HLWjHLB3S4KTKweQtHcfPrse5LuOxJfrv4bKnaFnQypLUUZPdd 6nJ9uf135Jor3rZnaVGRJLCovHNnowDT4eUy+cHskTvyHOXtoimiLFgOPhXPJFKK gzlwLf0+zAnr6+TU1FwP4NxghRDfbdf2FSNh2wDmUxZuHsK6Y9BuqNUI/R9at3Iq Un09i33ve4Ha1WYgYSYEd0P4IGjUgHOB12dntxBDIpDqJBd2r6MEMmmC+RK9oW9z ETVyBkZoMu8kkinn3pINke254Z/ow4GE9XURzGVNVWuC3L066M/DpwQTsk4g1GxT 8IQIcwvdPFgQ0RjGA9ZtuUFG/ECU1CtxdScAVK4iZs8pl2o0euur9QF5PY0DRfKw l6nNnb3vFVPkbmywsecZ2aXhJw0uYLHrbrmo+e3tnEcz8glpHhaO+gdyZ4V5TVC4 ZiUzEPDliW/OZMjLMNX1HnwDTxDgp0Vp9oEK+CfwIZkTKwOL+67933OT+CgFk5Rx vIY0wtFJ =adIE -----END PGP SIGNATURE----- --CFpUGzo7LKmGH3bN--