Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB0CC636CC for ; Thu, 16 Feb 2023 10:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbjBPKz5 (ORCPT ); Thu, 16 Feb 2023 05:55:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230254AbjBPKzu (ORCPT ); Thu, 16 Feb 2023 05:55:50 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A45ADC166 for ; Thu, 16 Feb 2023 02:55:31 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1pSbvE-0001F5-GS; Thu, 16 Feb 2023 11:55:28 +0100 Date: Thu, 16 Feb 2023 11:55:28 +0100 From: Phil Sutter To: Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nf-next PATCH v2] netfilter: nf_tables: Introduce NFTA_RULE_ACTUAL_EXPR Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Feb 07, 2023 at 11:56:53AM +0100, Phil Sutter wrote: [...] > Yes, please! I'll finish user space this week. :) Famous last words. :( I realized anonymous sets are indeed a problem, and I'm not sure how it could be solved. I missed the fact that with lookup expressions one has to run the init() callback to convert their per-batch set ID into the kernel-defined set name. So the simple "copy and return nla" approach is not sufficient. Initializing all of the dump-only expressions though causes other unwanted side-effects, like e.g. duplicated chain use-counters. One could ban lookup from being used in dump-only expressions. Right now, only ebtables' among match requires it. To still allow for ebtables-nft to use the compat interface, among match could be rewritten to use the legacy extension in-kernel. This doesn't solve the original problem though, because old ebtables-nft versions can't parse a match expression containing among extension. Another option that might work is to parse the dump-only expressions in nf_tables_newrule(), dump them into an skb, drop them again and extract the skb's buffer for later. Do you have a better idea perhaps? I'm a bit clueless how to proceed further right now. :( Cheers, Phil