Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D7BFC636CC for ; Tue, 7 Feb 2023 16:59:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EF640860EC; Tue, 7 Feb 2023 17:54:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fuanJ2Cg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 47CE0860FB; Tue, 7 Feb 2023 17:54:16 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 36BEC860C2 for ; Tue, 7 Feb 2023 17:53:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id f10so17448009qtv.1 for ; Tue, 07 Feb 2023 08:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=acaZJE9Egieeosvh5bHaqjDlBSyAOeucJdX+v24OcI0=; b=fuanJ2Cg9CtzA2c+gk+XLBY09AIXUBJByxc/3BzGHufExH5XPE8/rcUyWQci+DBoCN 6xytWdg7V5kvvdRErTQhGwoCKnsIsyuYF6nF8hRI7xN78BBPqG0CYURlCw7AUoX5aJkB sNiqthDndEneZfC9zqhACNylaTWqgQr4NTEA0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=acaZJE9Egieeosvh5bHaqjDlBSyAOeucJdX+v24OcI0=; b=VZNzA+a/eWcQJU/fl94snYgCulcREfgdh4E2MvSX3ZkTYZ4ocA755QWUm8il871dn9 P+CMD+uQ8DYFm0qlZxQ3gX3Y5q08hbqOO6VLme46Q/uJ7dyon3eHFyjBJiKh3RllJ6yK N82zjz7gBkeme0PFtXzSGCvrdYowCVRHvkBqWc4bq7kw62Xxh1DBjs1nZZc6bCZ3bGrE 7TLQTOknj++2RoL3dEd3wTBfbyvcngQ4IpfOKlHlpDaC0cjSBZgskw8WIv6YJHMdWwAO wlqYRv3k8lvlspFbHQuyGtFRoag+ByWeuLOu7O1I2rDmeJZbo25hptu5GQZgxrcf76pZ Xd/A== X-Gm-Message-State: AO0yUKWJkGfWK0TEtpWoYWKHmYURY2MD1vD+zwRF8hfdLBxPspeEgoR7 AAcF979ffKgRXmkKzxjZn4rYlUwIBHiwcYs/8rM= X-Google-Smtp-Source: AK7set+hxFeWUyzB8WAjLtZNV/JPrxDAWc2DMqQ61Oewfq6oT4b9mrgOyxgpZa2PHaXCMLPvS4T+ag== X-Received: by 2002:a05:622a:38a:b0:3b8:6c8e:4f8d with SMTP id j10-20020a05622a038a00b003b86c8e4f8dmr6233520qtx.68.1675788798031; Tue, 07 Feb 2023 08:53:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7494-fb31-9b5f-683c.res6.spectrum.com. [2603:6081:7b00:6400:7494:fb31:9b5f:683c]) by smtp.gmail.com with ESMTPSA id e13-20020ac8414d000000b003b868cdc689sm9879637qtm.5.2023.02.07.08.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:53:17 -0800 (PST) Date: Tue, 7 Feb 2023 11:53:15 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type Message-ID: References: <20230129164555.9940-1-pali@kernel.org> <20230129164555.9940-3-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j43LAvIY8SEpP1W9" Content-Disposition: inline In-Reply-To: <20230129164555.9940-3-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --j43LAvIY8SEpP1W9 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 29, 2023 at 05:45:55PM +0100, Pali Roh=E1r wrote: > gpimage type requires only that two first 32-bit words of data file are > non-zero. So basically every random data file can be guessed and verified > as gpimage. So completely skip gpimage type from image autodetection code > to prevent lot of false positive results. Data file with gpimage type can > be still verified and parsed by explicitly specifying -T gpimage. >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --j43LAvIY8SEpP1W9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPigfsACgkQFHw5/5Y0 tyxSRQwAgSd8AC13Evaawh/IZJSQuH3i8kpWejmlvIIRiB1NqPbzU+s8h14AUgVm uZ11KZSN0Kxfkqn0BbbwrqC68d8xzjsU5K/Pp3wuzhLYs6KmbVwb0O/tfpIJbGf7 PEu1YA8LQ1ITu8rxPjB7E9umk8QzAcWWpcvpPSqIcUAZm32jv0DYflWEOGOhzPYy o3ufHzxg5y8KM6pgSl+nbvlKxxjWWI4PcvGiaaREQryDw8NHvTR3sofnisOHeN1b 8W/GESP6WJmXjmktPoqWppxSdRH4/6f4h45t/lguDiy50hV9gTfXaU5kzd8sOqAl awTftcg7GoI5yj/CaBzhn62zwnY+yFH8DUSgu+34OtO6Eia1WDmTdmSAVTh+hTc2 LCclIdva5Iz2V040cGvSrpUm12fPOip6vpbFa3PWtFOPSBc2YLndmEqiDaZBScW6 ah+PH+VEMS5DmrvGKNnUvnN+J2Vn5AhKFfj94Zicnr7WnF+ojn/9P3ou1A9uSv0o +HVwh3pr =gaU/ -----END PGP SIGNATURE----- --j43LAvIY8SEpP1W9--