Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEDB2C636CC for ; Tue, 7 Feb 2023 16:59:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AF5668610D; Tue, 7 Feb 2023 17:54:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LCt7NklH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B6D086088; Tue, 7 Feb 2023 17:54:16 +0100 (CET) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A37E860D9 for ; Tue, 7 Feb 2023 17:54:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82b.google.com with SMTP id g18so15110013qtb.6 for ; Tue, 07 Feb 2023 08:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YVkMOn0hx4sWdLvI8O6VnHxHKS96iGNWt06uRVSANZs=; b=LCt7NklHayCZcwcU53KH5hEKGqhDI88aGBhTQORcRii8StsGXxsDmdk/ZDJnkVuP28 nq/EEPb7FaWHbiK2nZ/iYCDWRsUj+K+GFlJsM/hhVDtKRUxnOBVIblvFHelED0qWmTS8 NgL8lFC8nUE9D9bt9tjZ8bWbQ00Ibcnd86Zfk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YVkMOn0hx4sWdLvI8O6VnHxHKS96iGNWt06uRVSANZs=; b=iM3GjLb18LXrGeCAxMFWNKmf8oDCuSHu/xDDxKKRRFoLDAVpeSstEqPN/zzpXKLT8i CpviQHSz+wFDO/X5boyFKU3e4UsKt7ilhi+z09ladUqx0ms/3kOEVUalG3BunfgFcijt 91j3iPwIvV+rx/av5TAZWyTYXIAR0+k4eWvbrCx7oO9CT/WXuqRQB0H7k5bzDFmIpM4h qgWqVNnoHeG8KsPgK4OPjRpTphVL6pGjfrSuFtzuzWsYBJImeXIdN55GCIX2JvqzepWl DEPbbOelJGo+40j7NYguiqLi8NO8brIUpkpO1YtF2nQAt6ni4akXGiAnCAd2i8oAFzk3 ptJw== X-Gm-Message-State: AO0yUKXYPWZ4WcAQ46VSpXquU83iMtNhhnKSkCML8yY9kUGv8mVFTKJQ 4Yujq6OBysHCiawLID04KE4j+w== X-Google-Smtp-Source: AK7set8DPyFKVqKjvLOkqdehshtIGgptSDOKb1gSKMJgqrxTyfxA6l84N61418jnmeVPw/3oAftcDg== X-Received: by 2002:ac8:4e46:0:b0:3ae:189c:7455 with SMTP id e6-20020ac84e46000000b003ae189c7455mr6286555qtw.47.1675788843098; Tue, 07 Feb 2023 08:54:03 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7494-fb31-9b5f-683c.res6.spectrum.com. [2603:6081:7b00:6400:7494:fb31:9b5f:683c]) by smtp.gmail.com with ESMTPSA id a26-20020ac8001a000000b003b85f9a56c9sm9522379qtg.97.2023.02.07.08.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:54:02 -0800 (PST) Date: Tue, 7 Feb 2023 11:54:00 -0500 From: Tom Rini To: Ye Li Cc: patrick.delaunay@foss.st.com, u-boot@lists.denx.de, patrice.chotard@foss.st.com, peng.fan@nxp.com, uboot-imx@nxp.com Subject: Re: [PATCH] env: mmc: Fix offset issue for env save Message-ID: References: <1675147318-75117-1-git-send-email-ye.li@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="29RaeA6ls670AyBr" Content-Disposition: inline In-Reply-To: <1675147318-75117-1-git-send-email-ye.li@nxp.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --29RaeA6ls670AyBr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2023 at 02:41:58PM +0800, Ye Li wrote: > Fix the issue in commit 46c9016 (env: mcc: Drop unnecessary #ifdefs) > If CONFIG_SYS_REDUNDAND_ENVIRONMENT is not defined, the offset value > becomes undetermined, so write env to unexpected offset. >=20 > Signed-off-by: Ye Li > Reviewed-by: Jaehoon Chung Applied to u-boot/master, thanks! --=20 Tom --29RaeA6ls670AyBr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPigigACgkQFHw5/5Y0 tywmEAv+JTHxulDpRkH3X7wUUgJ5L8Vsj1A4Sac4ZKPLdQb2kFjvS2sE7P63bdSJ h5+hngjChdlu4H4edbbHz1bAwVSjtFUqwKpJB8l97ugap5H9sQfwUOdi4MDOsLo9 O62uSe1MzmF+Z5Hk0YdSdZRFpUBqgUUZKMHLSybXg8ywokpl3qQxDQqHxYkkznMV Bmie5f13T+LUpc0uLJ2fRVLkyjor1a+YDFfmElJR4HOB4Xlx+x6CrF9hlZAWjs8z bxOIdRCV3ZMQWUoFahpNBGpQgbXnaWDlZTzyRxpjChCYNWmCXBVAC8csMvJdhb44 iWo8CbH9wCNmXBcaPa7IutkRQSbV61UUidIj1uUaU14Ax0qfVA4uJA1qQvc85m+i hsAzjgdhfVtbSySwmN3eCGmZSGUGzmFJE8JMvBXddrze7+4XzIr4b5vvY0peHKxm WtZb9I1xcpoGKMAxRj6Uud0wL4UEu7ewnd3Xq7KUrCwupphkQLHxgXpLhdODB5/L Wt38ivbO =grkx -----END PGP SIGNATURE----- --29RaeA6ls670AyBr--