Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13D8C636CC for ; Wed, 8 Feb 2023 01:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbjBHBsn (ORCPT ); Tue, 7 Feb 2023 20:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbjBHBsm (ORCPT ); Tue, 7 Feb 2023 20:48:42 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB8C524D for ; Tue, 7 Feb 2023 17:48:41 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id b5so17664301plz.5 for ; Tue, 07 Feb 2023 17:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QaWmVwukI1ayQ/CHcE8yufMV7Id8NI5E9IHNugGw6TE=; b=boeq3f5yUhZov8hpw0E8yN/K7WkvFei34Oba03Q9i/pDEyKo/o9qITtDfoz6R3zeaJ ahHw9iSTuVAv4aLCpbOh0vwFO+EjpQFl0YItr/XLLGRgkG/KCxY8r1YUh7uBxHEOfeah 8ag37wVrZoYsR+NuW3nA1zhNzJk/DhSzY4cUbqrCb2QBctLywku/lFYg2VeltvUNCRpQ 3beMQDNfG6D8KFB2YqvhlBeNLcBAKFS30vJbQ1s+7Lvup0W4X8jj1PpD5kYpqm5p0d2/ ln/QL9FqT0BTtryO06E7L9qnaf7eWqu09qY4lfdjTUpHv1js/g6XoRAnoEpXEiZTuMmk ZB7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QaWmVwukI1ayQ/CHcE8yufMV7Id8NI5E9IHNugGw6TE=; b=Ad5J/Yn/2P9NMW/qqZsMGaNa1HWgyKfQPD42Se1kSam/VDYiOjI7qtgDFgzOqCdK/t 3gXuG/hnkruaDfjylg7ufg+JQL6ZauSoyTIbSYlOp1uWzIWmGga6YBu8B0GuBaVVjr9e Rq2Fhavcvg4ZLU9UGu81M0UjpabLgc7FduI9K0X1I0AzBNxt4H5q9hK0j5cB37IhgDVZ k3Aa8SJsTJuxwhr1L/hHzfnmil7Xf4RR+T/dgPsjW3JgSmtE/5BfERl0G7+CW2tQlZmd JwPBcHyDP0VRdB5avwry8Mb0Q0ouGG+oOQg4YN3TYFoxHx5/6z28ZhWvAzIAB2ueoN2Q 4Ynw== X-Gm-Message-State: AO0yUKWTZoVsHxkaTTeVZLJB4bFbD5HXMuthPp/KbnCLw8A0v4i22Rj7 XrMoKBw6vJd8gYYB3fGJPOXvGg== X-Google-Smtp-Source: AK7set/pP1FRr7jt6j9nqI06yKqTZM/V7+D23d9yLYh6Y7Vn/ookEMRRIWeJyV2n1HV21mzVW2fJhQ== X-Received: by 2002:a17:902:c20d:b0:198:af50:e4e0 with SMTP id 13-20020a170902c20d00b00198af50e4e0mr115157pll.6.1675820921284; Tue, 07 Feb 2023 17:48:41 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id jd22-20020a170903261600b001992fc0a8eesm2105493plb.174.2023.02.07.17.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 17:48:40 -0800 (PST) Date: Wed, 8 Feb 2023 01:48:37 +0000 From: Sean Christopherson To: Mingwei Zhang Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Venkatesh Srinivas , Aaron Lewis Subject: Re: [PATCH 4/4] KVM: selftests: x86: Repeat the checking of xheader when IA32_XFD[18] is set in amx_test Message-ID: References: <20230110185823.1856951-1-mizhang@google.com> <20230110185823.1856951-5-mizhang@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230110185823.1856951-5-mizhang@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 10, 2023, Mingwei Zhang wrote: > Repeat the checking of AMX component in xheader after xsavec when s/xsavec/XSAVEC. Not sure about xheader, though it seems like that should be capitalized too. > IA32_XFD[18] is set. This check calibrates the functionality scope of s/18/XTILEDATA > IA32_XFD: it does not intercept the XSAVE state management. I didn't follow this. Is this basically saying "Verify XTILEDATA is saved by XSAVEC even when disabled via IA32_XFD"? > Regardless of the values in IA32_XFD, AMX component state will still be > managed by XSAVE* and XRSTOR* as long as XCR[18:17] are set. > > Signed-off-by: Mingwei Zhang > --- > tools/testing/selftests/kvm/x86_64/amx_test.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c > index 18203e399e9d..9a80a59b64e6 100644 > --- a/tools/testing/selftests/kvm/x86_64/amx_test.c > +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c > @@ -235,6 +235,16 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, > > /* xfd=0x40000, disable amx tiledata */ > wrmsr(MSR_IA32_XFD, XFEATURE_MASK_XTILEDATA); > + > + /* > + * Bit 18 is cleared in XSTATE_BV but set in XCOMP_BV, this property s/Bit 18/XTILEDATA > + * remains the same even when IA32_XFD disables amx tiledata. I would phrase this as "even when AMX tile data is disabled via IA32_XFD". Software disables AMX, IA32_XFD is the mechanic by which that is done. > + */ > + set_xstatebv(xsave_data, XFEATURE_MASK_XTILEDATA); > + __xsavec(xsave_data, XFEATURE_MASK_XTILEDATA); > + GUEST_ASSERT((get_xstatebv(xsave_data) & XFEATURE_MASK_XTILEDATA) == 0); > + GUEST_ASSERT((get_xcompbv(xsave_data) & XFEATURE_MASK_XTILEDATA) == XFEATURE_MASK_XTILEDATA); Same feedback about using !(...) and unnecessary "== x". > + > GUEST_SYNC(6); > GUEST_ASSERT(rdmsr(MSR_IA32_XFD) == XFEATURE_MASK_XTILEDATA); > set_tilecfg(amx_cfg); > -- > 2.39.0.314.g84b9a713c41-goog >