Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D615C636D6 for ; Thu, 9 Feb 2023 16:52:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 35BFC857BC; Thu, 9 Feb 2023 17:52:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uKBvR4LI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 792EA8586B; Thu, 9 Feb 2023 17:52:14 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE09E85841 for ; Thu, 9 Feb 2023 17:52:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id c2so2640839qtw.5 for ; Thu, 09 Feb 2023 08:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cgNg6JegdFQe1zTakkEHApcojg8g9qgiXnq5fLywgi4=; b=uKBvR4LIR006lRI0W0VlLAOQA5mbyuwIZwFHYJhNb8I/tlWgFqQ/lZq0MTyyC8zmuf jwxjEO99GCgItFmfTuWurMVWQ+svfpLUGpP5FeJjw6DHfP65bER/G3bY0VPEai6xjJBL 4ilPQdSbloU32osz1hkvmFUC7I/StXqlTd7Oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cgNg6JegdFQe1zTakkEHApcojg8g9qgiXnq5fLywgi4=; b=67hIt76g7dE5pFL0xmnMHEEZJYRAaJtOf1W0jWXhpLnj+y6LB5C8yIrQEouWX3/asd WND84VJ04BaA+g5nUxFMkzXKhVf8DBwdFuSGabqVj8z5qyd+czenwUlp4dWcGmaazp5O G/nQWtkAhywetpMNDsHobDXu1nzIfcKAXQWnKHXqwqqYmNwSc4pQBj6bftqNtIOqvWtn JcxwGGszlZ2vjJUfqIeqSSTfaztgDSycBKEyYyBiGmRsHNtYT4hBXXjhTsojhAwXlO6V NoUR4/E49+nqXOgWFpak/aHdg/n0RqW3sBcPSeHKu/aLE50PG+njVCBY8qIVU23WNS7A 4KFg== X-Gm-Message-State: AO0yUKW29EtKqSYx5t+R3sgLA363uFPZzJuiG2DRsQsFWVffvFa/VUpc QcQPAxPeszl8CQ4G5CLRJN6R7A== X-Google-Smtp-Source: AK7set/nCLTqGZ4QRrfPSKcO7OGhbUKDg2ux9e5VmVIPAdT7gv2r25hBWGiFuzwi570FxIc9jds1bQ== X-Received: by 2002:a05:622a:611:b0:3b9:bcac:725b with SMTP id z17-20020a05622a061100b003b9bcac725bmr21374713qta.22.1675961527635; Thu, 09 Feb 2023 08:52:07 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-538d-baa1-e57f-2a07.res6.spectrum.com. [2603:6081:7b00:6400:538d:baa1:e57f:2a07]) by smtp.gmail.com with ESMTPSA id t13-20020ac86a0d000000b003b82a07c4d6sm1549452qtr.84.2023.02.09.08.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 08:52:07 -0800 (PST) Date: Thu, 9 Feb 2023 11:52:05 -0500 From: Tom Rini To: Frieder Schrempf Cc: Frieder Schrempf , u-boot@lists.denx.de, Jagan Teki , Mikhail Kshevetskiy , Miquel Raynal , Simon Glass , Stefan Roese , Michael Trimarchi , Dario Binacchi Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation Message-ID: References: <20230110115843.391630-1-frieder@fris.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2S6ssj4VS6Hhb3IU" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --2S6ssj4VS6Hhb3IU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: > Hi, >=20 > On 10.01.23 12:58, Frieder Schrempf wrote: > > From: Mikhail Kshevetskiy > >=20 > > Currently there are 3 different variants of read_id implementation: > > 1. opcode only. Found in GD5FxGQ4xF. > > 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > > 3. opcode + 1 dummy byte. Found in other currently supported chips. > >=20 > > Original implementation was for variant 1 and let detect function > > of chips with variant 2 and 3 to ignore the first byte. This isn't > > robust: > >=20 > > 1. For chips of variant 2, if SPI master doesn't keep MOSI low > > during read, chip will get a random id offset, and the entire id > > buffer will shift by that offset, causing detect failure. > >=20 > > 2. For chips of variant 1, if it happens to get a devid that equals > > to manufacture id of variant 2 or 3 chips, it'll get incorrectly > > detected. > >=20 > > This patch reworks detect procedure to address problems above. New > > logic do detection for all variants separatedly, in 1-2-3 order. > > Since all current detect methods do exactly the same id matching > > procedure, unify them into core.c and remove detect method from > > manufacture_ops. > >=20 > > This is a rework of Chuanhong Guo patch > > submitted to linux kernel > >=20 > > Signed-off-by: Mikhail Kshevetskiy > > Signed-off-by: Frieder Schrempf >=20 > +Cc: Jagan, Tom >=20 > Who is supposed to pick up these patches? Some of them have been around > for some months (before I resent them). >=20 > There is no maintainer for drivers/mtd/spinand/ and no maintainer for > drivers/mtd/ in general. >=20 > In Patchwork Jagan got assigned, but the get_maintainer.pl script didn't > even add him to Cc, of course. >=20 > Any ideas how to proceed? We don't have anyone dedicated to that area, yes, sadly. I've added Michael and Dario as they've also been doing mtd-but-not-spi work of late to see if they're interested. Or since you've long been working here, would you like to more formally maintain the area? Thanks! --=20 Tom --2S6ssj4VS6Hhb3IU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPlJLEACgkQFHw5/5Y0 tyy9GAwAghiZA3i7LwnLCQiRDymcAeWepaENMTjdnwXYReFprFS08jAPoEetPL/c 2k4iPD3O0mXnZO1rI6bXRa2TZCdgsEo/uOAjHX4/w5QpAFcl9g5go5AOXEMFV2gi /rMv1I1hjTfWojHiRJEKkQ1GXzvZSXn6Ew7uIq8cJGVcmBzmSASXtcMBZZlQCzuY 2TrW823ZEf6+OMMnr2iX3pnIr9EopNu0uwdeoZUe04r/XQXNFl4yfvo+luTMNXAR NDGk1o8zKOL3nygStEZYmNkC0dJ2/zr1VY8LACM5K29S67f3+PXda1cUyUttb1Pv AyWFH66H78C463HwN55SQH7scI+c5pXcMjdSuKvDJSeOGFwMsE4m6CBy9bmFbP9r zJAyjKPW9jLyT/iv2XvxaxnjcVb1KXZdAHY8xv6juZ2lQVNNH305mhq6bedq6tud 8gNpMqxyYIbEyoJaIC9SBPJKs+YcUvfbzNoeCVM2qe4KG2JKd9XoaOycvrHZdlyQ BCY7Q88v =yF+3 -----END PGP SIGNATURE----- --2S6ssj4VS6Hhb3IU--