Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A508C05027 for ; Sun, 12 Feb 2023 17:47:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C498583523; Sun, 12 Feb 2023 18:47:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="gRIYO6Nx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CBB1684167; Sun, 12 Feb 2023 18:47:34 +0100 (CET) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CD6AB8340F for ; Sun, 12 Feb 2023 18:47:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id y2so1525522qvo.4 for ; Sun, 12 Feb 2023 09:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b/ZCoB6/Oj0fZGGnjwfQffQhica4lpU2NuHBntfiQw4=; b=gRIYO6NxDxfFiX34RnDLL2e0IsBy+CzB05xag3LkOnQ2RBilQB+GGK5Y1y8BJ4Pj/Z DVpbBZBkmo4YyZSop+T/4/VYeyZwl8E+6baU7PyUGyM+lJobWiPqDpv2BK8iglD5Gnw0 n0EgdRf0K2QCfP7OooFXJs6oebcy/e6X7F2ZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b/ZCoB6/Oj0fZGGnjwfQffQhica4lpU2NuHBntfiQw4=; b=zrk9+qG8esH+xwo8t6OQXGnjAxWwWH4fMJ9qsX5AYI1EWOvpdXaLvY7g8BIvCyv9Sb 19dBEN1+NIlKjP7wgG1K7v+mwzDTe/+dG73L517bxVT7GSasvU74b5XIjZkg8H4E7KYF u3zHqvFPFkj3ZjQtRmneWGhdf0GS2y9v9Q1fVlNJ4/z+DQRc5xduiXSX5ejcxDRqwmvt ZfahjzXoHaWEoJA2tfPcuweS1kd3I6A2o0XS8joLx6h/aTvJDJv8D73vYT9rDE7Aq+7g blToSH6ZSZ2tVMlOQ320jPREaTKz4O2q+WDrTU7HxffHTDd+S+FAgPGs+AF0crktYlTP fJ1Q== X-Gm-Message-State: AO0yUKWR+gPq2fxEJWj5BNJn0HDftfmiXEG00ImtYltfe7coyyzeBoWZ Xq6L8tf6zH7oRo0am2aHic61zg== X-Google-Smtp-Source: AK7set857EgQ3lPrs2hLsjmiy9uckejuesQBdSXfjYfHzf9fNRIFgzy4spKhoVcHasZJ1zreXA3Jug== X-Received: by 2002:ad4:5942:0:b0:56c:25dd:f73a with SMTP id eo2-20020ad45942000000b0056c25ddf73amr24223414qvb.21.1676224050640; Sun, 12 Feb 2023 09:47:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3561-74c6-8bcf-1616.res6.spectrum.com. [2603:6081:7b00:6400:3561:74c6:8bcf:1616]) by smtp.gmail.com with ESMTPSA id j64-20020a378743000000b0073b275607f0sm2963593qkd.65.2023.02.12.09.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 09:47:30 -0800 (PST) Date: Sun, 12 Feb 2023 12:47:28 -0500 From: Tom Rini To: Adam Ford Cc: u-boot@lists.denx.de, aford@beaconembedded.com, Stefano Babic , Fabio Estevam , "NXP i.MX U-Boot Team" Subject: Re: [PATCH] arm64: imx: Add support for imx8mp-beacon-kit Message-ID: References: <20230212173639.487374-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AslCC/Qe6D0OyKp8" Content-Disposition: inline In-Reply-To: <20230212173639.487374-1-aford173@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --AslCC/Qe6D0OyKp8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 11:36:38AM -0600, Adam Ford wrote: > Beacon Embedded has an i.MX8M Plus development kit which consists > of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, > and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual > Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet > PHY. The device trees are already queued for inclusion in Linux 6.3. >=20 > Signed-off-by: Adam Ford [snip] > diff --git a/board/beacon/imx8mp/README b/board/beacon/imx8mp/README > new file mode 100644 > index 0000000000..47999bb038 > --- /dev/null > +++ b/board/beacon/imx8mp/README Our rST docs have gotten to the point I think where we should say no to new board README files, this belongs under doc/board/ [snip] > +#define CFG_EXTRA_ENV_SETTINGS \ > + "scriptaddr=3D" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ > + "kernel_addr_r=3D" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ > + "image=3DImage\0" \ > + "console=3Dttymxc1,115200\0" \ > + "fdt_addr_r=3D0x43000000\0" \ > + "fdt_addr=3D0x43000000\0" \ > + "boot_fdt=3Dtry\0" \ > + "boot_fit=3Dno\0" \ > + "fdt_file=3D" CONFIG_DEFAULT_FDT_FILE "\0" \ > + "bootm_size=3D0x10000000\0" \ > + "mmcdev=3D1\0" \ > + "mmcpart=3D1\0" \ > + "optargs=3Daudit=3D0 video=3DLVDS-1:d video=3DLVDS-2:d\0" \ > + "finduuid=3Dpart uuid mmc ${mmcdev}:2 uuid\0" \ > + "mmcargs=3Dsetenv bootargs console=3D${console} " \ > + " root=3DPARTUUID=3D${uuid} rootwait rw ${mtdparts} ${optargs}\0" \ > + "bootscript=3Decho Running bootscript from mmc ...; " \ > + "source\0" \ > + "loadimage=3Dfatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \ > + "loadfdt=3Decho ${fdt_file}; fatload mmc ${mmcdev}:${mmcpart} ${fdt_add= r_r} ${fdt_file}\0" \ > + "mmcboot=3Decho Booting from mmc ...; " \ > + "run finduuid; run mmcargs; " \ > + "if test ${boot_fit} =3D yes || test ${boot_fit} =3D try; then " \ > + "bootm ${loadaddr}; " \ > + "else " \ > + "if run loadfdt; then " \ > + "booti ${loadaddr} - ${fdt_addr_r}; " \ > + "else " \ > + "echo WARN: Cannot load the DT; " \ > + "fi; " \ > + "fi;\0" \ > + "netargs=3Dsetenv bootargs ${jh_clk} console=3D${console} " \ > + "root=3D/dev/nfs " \ > + "ip=3Ddhcp nfsroot=3D${serverip}:${nfsroot},v3,tcp\0" \ > + "netboot=3Decho Booting from net ...; " \ > + "run netargs; " \ > + "if test ${ip_dyn} =3D yes; then " \ > + "setenv get_cmd dhcp; " \ > + "else " \ > + "setenv get_cmd tftp; " \ > + "fi; " \ > + "${get_cmd} ${loadaddr} ${image}; " \ > + "if test ${boot_fit} =3D yes || test ${boot_fit} =3D try; then " \ > + "bootm ${loadaddr}; " \ > + "else " \ > + "if ${get_cmd} ${fdt_addr_r} ${fdt_file}; then " \ > + "booti ${loadaddr} - ${fdt_addr_r}; " \ > + "else " \ > + "echo WARN: Cannot load the DT; " \ > + "fi; " \ > + "fi;\0" And this should all be plain text environment (see board/*/*/*.env for examples), and please put it somewhere on your TODO list to migrate other platforms README and environments, thanks! --=20 Tom --AslCC/Qe6D0OyKp8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPpJjAACgkQFHw5/5Y0 tywwfgv/btglA1FD3hHw+EMDUcAzV1NsO13I2g6q4zfR6ZkDf7a3FXEj8GqRuA7O 0x/MiiEQMD5h2mK6+HWOgJjXQJa9A2V1H/mx3+ADS8lJHLZxyothyxZkhFV7f3me MTXqGe2su1bIzWdin6HPwroZmoemTopVOxMngCS5EJZQrotFbcGImsICbFnri5tp NXg8WgmpiSqvjD62gEsBxd431wOgJMnZ9L5m1wGxQoevpcsAmj3hb1nyAos/evFC iWlCQK2z82Ok7L0YLT7CCsfu/eo0s1YAmZmT/WGOT0/HE+mGvPMyT3z4jagW5GO3 chaMi2WvYwwSbbsZGr+f82HctYkHEyTJGud4AALVoBd10ZwQSrXVtDjkbQKlFNSs 6tR5ASOJRH5p0Ct0xSFgDz47MKzf7vOPiwfF7BfhWQ7VZ5XvwIFnpqPoR+w7+/+D IdupFH9chAOi4QKpEcfcN6ht3UcvrWlR1ekS2/6O/rkJyIbvDBZbWuGCL5Aq2FkK 47P0L5Fk =SToX -----END PGP SIGNATURE----- --AslCC/Qe6D0OyKp8--