Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBC4EC636D4 for ; Mon, 13 Feb 2023 15:09:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3C9648532C; Mon, 13 Feb 2023 16:09:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LOXrF1gy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2637A802B4; Mon, 13 Feb 2023 16:09:34 +0100 (CET) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 46C0080BA5 for ; Mon, 13 Feb 2023 16:09:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id c2so14016533qtw.5 for ; Mon, 13 Feb 2023 07:09:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z+UEqGBEThLQtPNHK7r0R6s7H7zSOzREdeR0pto9tOY=; b=LOXrF1gyO3RO0ptUQ2zNHHgchunrCMIFcIZPHlcwVcQK8YdfkTwVdNV/vOxMG11W56 ByQYWLC+0E0GcTZW0f6rktELp6V0bmVd9fcfuzCn/IZCoF+KBf6n1JNYb0QLEUnJemjl M2QwU/T/a0GNRFgnQIw8T63ydg1CEVCU96yww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z+UEqGBEThLQtPNHK7r0R6s7H7zSOzREdeR0pto9tOY=; b=xJQhRI0VN0gEFdhPBCLAZm0dY4YL/iG4E17hbkAI1z1Dc0mhJajZQATA2D1Zqnqg8p oCldIaM6KBz6bheRbKcRhDUgc9S3nYvALVt5AYVUsJfyyIxqH7lyqks3aJ2+j4vud/Ke qDyOOOoXjllvL7ey+gkEiD5VkO2Esrvhf/ahDeXJ/ycm+lkFW8FBadOnTAzP0h6/hcD8 pKijowhqU6pnIartOZevgJ5tc6GdQf62uexLr9tQJfhvunHN55AdlcybHbBKJx9cmJlA jfgyi2SWol2I3qzIj6yPGFOjZM5g87x+QrbGVUHecljdN2xroBTz3ue+kQL6HsNiupQ/ n3zw== X-Gm-Message-State: AO0yUKUxzAIalqQrs5DUer5ZVO4ZVJReJRT+R8Ml6ybvgmxgVt9piGNd iUMBmy+2lWycs0qzFYHYmxMEew== X-Google-Smtp-Source: AK7set+OXAw6sg3JA7umOvD1EMoP4isVAtRUv3NdJRdxKTlgSoZD8B4iHvGHCsa1VW1FwFds6VtE4Q== X-Received: by 2002:ac8:59c1:0:b0:3b9:b2ba:9b3d with SMTP id f1-20020ac859c1000000b003b9b2ba9b3dmr42371058qtf.54.1676300965952; Mon, 13 Feb 2023 07:09:25 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b26c-1f7f-442c-b848.res6.spectrum.com. [2603:6081:7b00:6400:b26c:1f7f:442c:b848]) by smtp.gmail.com with ESMTPSA id 63-20020a370842000000b006f9f714cb6asm9749295qki.50.2023.02.13.07.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 07:09:25 -0800 (PST) Date: Mon, 13 Feb 2023 10:09:23 -0500 From: Tom Rini To: Adam Ford Cc: u-boot@lists.denx.de, aford@beaconembedded.com, Stefano Babic , Fabio Estevam , "NXP i.MX U-Boot Team" Subject: Re: [PATCH V2] arm64: imx: Add support for imx8mp-beacon-kit Message-ID: References: <20230212235736.505361-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yS7IDYZJys1t+Lsj" Content-Disposition: inline In-Reply-To: <20230212235736.505361-1-aford173@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --yS7IDYZJys1t+Lsj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 05:57:35PM -0600, Adam Ford wrote: > Beacon Embedded has an i.MX8M Plus development kit which consists > of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, > and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual > Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet > PHY. The device trees are already queued for inclusion in Linux 6.3. >=20 > Signed-off-by: Adam Ford [snip] > diff --git a/board/beacon/imx8mp/imx8mp_beacon.env b/board/beacon/imx8mp/= imx8mp_beacon.env > new file mode 100644 > index 0000000000..ba9f1e462f > --- /dev/null > +++ b/board/beacon/imx8mp/imx8mp_beacon.env > @@ -0,0 +1,29 @@ > +arch=3Darm > +baudrate=3D115200 > +board=3Dimx8mp > +board_name=3Dimx8mp You don't need to specify the variables that will be set via include/env_default.h (and if you see an example that is, whoops), just what you normally would have put in CFG_EXTRA_ENV_SETTINGS. I see a few more in here as well that should be pulled. > diff --git a/doc/board/beacon/beacon-imx8mp.rst b/doc/board/beacon/beacon= -imx8mp.rst > new file mode 100644 > index 0000000000..375931c07d > --- /dev/null > +++ b/doc/board/beacon/beacon-imx8mp.rst > @@ -0,0 +1,52 @@ I _think_ this is fine itself, but please run 'make htmldocs' (see doc/build/documentation.rst for instructions) as I'm pretty sure you didn't since this is a new directory and so index files need to be updated too. [snip] > +++ b/include/configs/imx8mp_beacon.h > @@ -0,0 +1,31 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright 2022 Logic PD, Inc dba Beacon EmbeddedWorks > + */ > + > +#ifndef __IMX8MP_BEACON_H > +#define __IMX8MP_BEACON_H > + > +#include > +#include > +#include While I'm seeing it again, do we _really_ need these includes here? > +#define CFG_SYS_UBOOT_BASE (QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_= U_BOOT_SECTOR * 512) > + > +#if defined(CONFIG_CMD_NET) > +#define PHY_ANEG_TIMEOUT 20000 > +#endif > + > +/* Link Definitions */ > + > +#define CFG_SYS_INIT_RAM_ADDR 0x40000000 > +#define CFG_SYS_INIT_RAM_SIZE 0x80000 > + > +/* Totally 6GB DDR */ > +#define CFG_SYS_SDRAM_BASE 0x40000000 > +#define PHYS_SDRAM 0x40000000 > +#define PHYS_SDRAM_SIZE 0xC0000000 /* 3 GB */ > +#define PHYS_SDRAM_2 0x100000000 > +#define PHYS_SDRAM_2_SIZE 0xC0000000 /* 3 GB */ And are all of these still, strictly, required? I can accept that they are but it's good to confirm, as part of the CONFIG migration work I saw a lot of seemingly not needed anymore defines in config header files, and we're getting closer now to being able to make the file optional. --=20 Tom --yS7IDYZJys1t+Lsj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPqUqAACgkQFHw5/5Y0 tyxNewv/SdPWGyh5HL8Kg3Zj5JmBoXaxz+5cA73C6FUpTxOzJbjDLPkfKwmwPWbv PaZLujvoOkcFJ4EDwopngG7x8IEgC81BlWKCJ0umAK4s3GhslPa8cwvzKcfCK0cN RVmpMf/Ox6EGyELNiLayTGYAglzf+tXCZYUh+VYTqamI47YZ0ZZua4DYDI7CIjcZ yHlW89oyLGX3pk1ateyphhEPwLVAZWrq2DtrRkXO9OZWcfl547R8oXAEjPyIEh5m nlRE+P0xaCAaLuRy1l51tgloTnX2Bct2az4zZJKpNdyCUooM72+ceOgcuBhMLsiy pQbR0mJO53MgSuDcCmEyyjtoUVQ5Yk8pNsQ0zli6hyptEe0/kdGcaBWeM4NVekhq MwavV42QLXj84kjNKQWGeaVkpvpprbAfc+IJCdKkLikI2s5+rNrqDZFNsmo/CG8a 7+KaTU1OmsbMZuwjDj9Ru09dUKLorNJRgC03gstWpMrUO2Bq4U5i2TV6aqwGtAW7 tn/woZir =g9Mq -----END PGP SIGNATURE----- --yS7IDYZJys1t+Lsj--